Issue-comments: strikethrough applied filter names #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better distinguish the filters that are being applied by using a strikethrough on the relevant applied filter name.
darkred
changed the title
|
Thanks @darkred! I had a busy day, I'll try to look at this tomorrow. |
- Fixed the selector to also apply to applied filters that have no content. - Also, changed the position of the rule, to maintain the existing order of the CSS rules
|
I've just fixed the selector I use in my PR, to also apply to the applied filters that have no content. |
|
Ok, this looks like a nice addition. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better distinguish the filters that are being applied, by using a strike-through on the applied filter names.
I hope you like my suggestion, @Mottie 🙂
Animated screen capture comparison:
Currently:
My suggested change: