Skip to content

Fix effect table by removing hrs and asterisks #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

JakeLegendXIII
Copy link
Contributor

@JakeLegendXIII JakeLegendXIII commented Jun 18, 2024

This is to fix issue #19

The (---) hr character is not always supported in markdown parsing and seems to be causing the issue here. It shows up good in VS and GitHub md preview, but is not making it into the html. Removing it actually seems to look okay as the generated tables have outlines and a good amount of spacing around them.

The asterisks were not breaking anything, but get printed as just literal asterisks. Not sure if that is intentional so I just removed them because it seems to look better and is easier to copy without them. Let me know if I should not have done that!

Here is a preview image:

image

@dellis1972
Copy link
Contributor

@JakeLegendXIII excellent, thanks for this 👍 I was wondering what was causing the problem.

@dellis1972 dellis1972 merged commit 3013c0a into MonoGame:main Jun 18, 2024
2 checks passed
@JakeLegendXIII JakeLegendXIII deleted the feature/format-table branch June 19, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants