Skip to content
This repository was archived by the owner on Jul 13, 2020. It is now read-only.

module tag support #156

Closed
wants to merge 1 commit into from

Conversation

calvinmetcalf
Copy link
Contributor

No description provided.

@calvinmetcalf
Copy link
Contributor Author

and this looks bigger then I intended because I switched the

if (browser){
    everything
} 
somethingSmall

to

if (!browser){
    somethingSmall
    return;
}

everything
somethingSmall

to avoid all the functional declarations inside of ifs which are technically illegal from what I remember.

@guybedford
Copy link
Member

This is looking awesome. Thanks for posting.

I'm just wondering if we should rather put this code inside Traceur since it is only suitable when Traceur is also present anyway.

@guybedford
Copy link
Member

Posted here - google/traceur-compiler#1114

@guybedford guybedford mentioned this pull request Jun 21, 2014
@guybedford
Copy link
Member

Actually this project is probably the best location for this work so I think we should go ahead with this PR... it could also be possible to have CommonJS and AMD within a tag with the right configuration, making it more useful here too in production scenarios.

@guybedford
Copy link
Member

The module tag is still somewhat uncertain, so for the foreseeable future the polyfill is sticking with <script type="module">

@guybedford guybedford force-pushed the master branch 5 times, most recently from 8053538 to 0f4d801 Compare September 29, 2014 10:01
@guybedford guybedford force-pushed the master branch 5 times, most recently from 19921ce to cc53028 Compare November 18, 2014 13:52
@guybedford guybedford closed this Dec 15, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants