Skip to content
This repository was archived by the owner on Jul 13, 2020. It is now read-only.

Commit 4f208b6

Browse files
committed
Merge pull request #259 from nevir/scriptmodulefix
Use global System for script type="import"
2 parents 69481de + 0d9fcf6 commit 4f208b6

7 files changed

+16
-7
lines changed

dist/es6-module-loader-sans-promises.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/es6-module-loader-sans-promises.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/es6-module-loader-sans-promises.src.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1484,7 +1484,10 @@ function logloads(loads) {
14841484
var script = scripts[i];
14851485
if (script.type == 'module') {
14861486
var source = script.innerHTML.substr(1);
1487-
System.module(source)['catch'](function(err) { setTimeout(function() { throw err; }); });
1487+
// It is important to reference the global System, rather than the one
1488+
// in our closure. We want to ensure that downstream users/libraries
1489+
// can override System w/ custom behavior.
1490+
__global.System.module(source)['catch'](function(err) { setTimeout(function() { throw err; }); });
14881491
}
14891492
}
14901493
}

dist/es6-module-loader.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/es6-module-loader.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/es6-module-loader.src.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2672,7 +2672,10 @@ function logloads(loads) {
26722672
var script = scripts[i];
26732673
if (script.type == 'module') {
26742674
var source = script.innerHTML.substr(1);
2675-
System.module(source)['catch'](function(err) { setTimeout(function() { throw err; }); });
2675+
// It is important to reference the global System, rather than the one
2676+
// in our closure. We want to ensure that downstream users/libraries
2677+
// can override System w/ custom behavior.
2678+
__global.System.module(source)['catch'](function(err) { setTimeout(function() { throw err; }); });
26762679
}
26772680
}
26782681
}

src/system.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,10 @@
291291
var script = scripts[i];
292292
if (script.type == 'module') {
293293
var source = script.innerHTML.substr(1);
294-
System.module(source)['catch'](function(err) { setTimeout(function() { throw err; }); });
294+
// It is important to reference the global System, rather than the one
295+
// in our closure. We want to ensure that downstream users/libraries
296+
// can override System w/ custom behavior.
297+
__global.System.module(source)['catch'](function(err) { setTimeout(function() { throw err; }); });
295298
}
296299
}
297300
}

0 commit comments

Comments
 (0)