Skip to content

[BUG] Two first color options display RdBU on current slide. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mmebsout opened this issue Mar 3, 2020 · 2 comments · Fixed by MizarWeb/DataCube#24
Closed

[BUG] Two first color options display RdBU on current slide. #24

mmebsout opened this issue Mar 3, 2020 · 2 comments · Fixed by MizarWeb/DataCube#24
Labels
bug Something isn't working Component:dataCube Data cube's component involved in the issue

Comments

@mmebsout
Copy link

mmebsout commented Mar 3, 2020 •
edited
Loading

USE CASE

  • Open DataCube
  • Change color choice to YIOrRd
  • PROBLEM => The slide changes to a color gradient going from blue->grey->red (RdBU)
  • Change slide by drag and dropping the slider cursor
  • The slide changes to color gradient going from red>->yellow (YIOrRd)

The same happens for the second gradient YIGnBu
(see matplotlib colormaps illustration for expected gradients)

EXPECTED =
When selected, the color choices "YIOrRd" and "YIGnBu" should be applied in the current slide instead of displaying a slide with the "RdBU" color gradient.
One shouldn't need to change slide to see the right color gradient in the slider.

image
@mmebsout mmebsout added bug Something isn't working Component:dataCube Data cube's component involved in the issue labels Mar 3, 2020
@mmebsout
Copy link
Author

mmebsout commented Mar 3, 2020

My bad it's a regression in my unpushed code.

@mmebsout mmebsout closed this as completed Mar 3, 2020
@mmebsout
Copy link
Author

mmebsout commented Mar 3, 2020 •
edited
Loading

Note: This is actually a Plotly.js problem that prevents me to use my fix for #20
I wrote a bug report to Plotly.js here

mmebsout added a commit to mmebsout/DataCube that referenced this issue Mar 5, 2020
@mmebsout
Typos in color gradients
ca5c129 
fixes MizarWeb/MizarWeb.github.io#24
mmebsout added a commit to mmebsout/DataCube that referenced this issue Mar 5, 2020
@mmebsout
Fixing lost traces when changing color or filter
89d8493 
fixes MizarWeb/MizarWeb.github.io#20 
fixes MizarWeb/MizarWeb.github.io#21

+ adjust typo in gradient names that fixes MizarWeb/MizarWeb.github.io#24
@mmebsout mmebsout mentioned this issue Mar 5, 2020
Merged
mmebsout added a commit to MizarWeb/DataCube that referenced this issue Mar 5, 2020
@mmebsout
Merge pull request #24 from mmebsout/lost-traces
a701e40 
Fixing lost traces when changing color or filter

fixes MizarWeb/MizarWeb.github.io#20
fixes MizarWeb/MizarWeb.github.io#21

adjust typo in gradient names that fixes MizarWeb/MizarWeb.github.io#24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Component:dataCube Data cube's component involved in the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing lost traces when changing color or filter mmebsout/DataCube
1 participant
@mmebsout