Skip to content

Conversation

@ncave
Copy link
Contributor

@ncave ncave commented Aug 22, 2016

Make all binary reader error messages the same (like this one) so they show the actual error, otherwise the actual error is obscured and hidden.

@msftclas
Copy link

Hi @ncave, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@KevinRansom
Copy link
Contributor

That's kind of a weird failure: @dotnet-bot test this please.

@KevinRansom
Copy link
Contributor

@ncave
It fails the same way on appveyor and in ci_part1 so I think there is something in the PR.
to repro:
build ci_part1

@ncave
Copy link
Contributor Author

ncave commented Aug 24, 2016

@KevinRansom Tests had to be fixed.

@ncave
Copy link
Contributor Author

ncave commented Aug 24, 2016

@dotnet-bot test this please

@ncave
Copy link
Contributor Author

ncave commented Aug 24, 2016

@KevinRansom I think the error in the AppVeyor ci_part2 build is unrelated to this PR, because I see the same error in a lot of other recent PRs:

Error running command 'C:\projects\visualfsharp-3dtit\tests\..\release\net40\bin\fsiAnyCPU.exe' with args ' -r:System.Core.dll --nowarn:20 --define:INTERACTIVE --maxerrors:1 --abortonerror test.fsx' in directory 'C:\projects\visualfsharp-3dtit\tests\fsharp\core\members\incremental'. ERRORLEVEL -1073740771 ERRORLEVEL -1073740771

@KevinRansom
Copy link
Contributor

@ncave ... yep I agree.

Thank you for taking care of this

Kevin

@KevinRansom KevinRansom merged commit 4dd4e1e into dotnet:master Aug 25, 2016
@ncave ncave deleted the patch branch August 25, 2016 21:53
@manofstick manofstick mentioned this pull request Oct 14, 2016
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants