Implementing Object.values and Object.entries

[akroshg]

These ES7 features are implemented as per the ES7 proposal https://github.com/tc39/proposal-object-values-entries/blob/master/spec.md. The implementation is predominantly based on the result of the Object.keys. unittest is added for more information about the usage.

[msftclas]

Hi @akroshg, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Akrosh Gandhi). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

[ljharb]

LGTM from a compliance angle :-)

[akroshg]

thanks @ljharb.
@abchatra - could you take a look at this one?

[goyakin]

Assume we have a non-enumerable property when this call is made. Between here and the IsEnumerable call on line 1134, it looks like it's possible to make the property enumerable. Wouldn't it be excluded from the result?

I see that we have tests for the opposite direction (i.e., enumerable -> non-enumerable), but we're missing this case.

[ljharb]

Good catch - the spec says that the list of existing own keys is fixed at the initial call, but that means a preexisting own key's enumerability can change in either direction during enumeration.

[akroshg]

@goyakin, I'll get back to you on this. It is good test case to add.

[akroshg]

@goyakin Yes there was issue in making non-enumerable to enumerable while iteration. I have fixed that and added the test cases.

[ljharb]

( ﾟ◡ﾟ)/