types: Make Data type-parameter optional in JsonRpcError

This is in order to provide backwards-compatibility with code
implemented towards v5.0.0.

Author: legobeat

jest.config.js

@@ -47,8 +47,8 @@ module.exports = {
     global: {
       branches: 94.31,
       functions: 94.11,
-      lines: 97.05,
-      statements: 97.05,
+      lines: 97.11,
+      statements: 97.11,
     },
   },
 

src/classes.ts

@@ -5,7 +5,11 @@ import {
 } from '@metamask/utils';
 import safeStringify from 'fast-safe-stringify';
 
-import { DataWithOptionalCause, serializeCause } from './utils';
+import type {
+  DataWithOptionalCause,
+  OptionalDataWithOptionalCause,
+} from './utils';
+import { serializeCause } from './utils';
 
 export type { SerializedJsonRpcError };
 
@@ -15,7 +19,9 @@ export type { SerializedJsonRpcError };
  *
  * Permits any integer error code.
  */
-export class JsonRpcError<T extends DataWithOptionalCause> extends Error {
+export class JsonRpcError<
+  T extends OptionalDataWithOptionalCause,
+> extends Error {
   public code: number;
 
   public data?: T;

src/utils.ts

@@ -27,6 +27,14 @@ export type DataWithOptionalCause =
       cause: unknown;
     };
 
+/**
+ * A data object, that must be either:
+ *
+ * - A valid DataWithOptionalCause value.
+ * - undefined.
+ */
+export type OptionalDataWithOptionalCause = undefined | DataWithOptionalCause;
+
 const FALLBACK_ERROR_CODE = errorCodes.rpc.internal;
 const FALLBACK_MESSAGE =
   'Unspecified error message. This is a bug, please report it.';