Gas customization features #5704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjm
force-pushed
the
new-gas-customize-feature-branch-d
branch
from
870351a to
4e0cf70
Compare
danjm
force-pushed
the
new-gas-customize-feature-branch-d
branch
from
f190265 to
a75f46e
Compare
danjm
force-pushed
the
new-gas-customize-feature-branch-d
branch
3 times, most recently
from
d8b101b to
ab75457
Compare
danjm
force-pushed
the
new-gas-customize-feature-branch-d
branch
2 times, most recently
from
d39c009 to
ecf439f
Compare
tmashuang
reviewed
Nov 28, 2018
| cancelAndClose: () => { | ||
| dispatch(resetCustomData()) | ||
| dispatch(hideModal()) | ||
| dispatch(hideModal()) |
There was a problem hiding this comment.
Test expects dispatch to be called twice, here we have three dispatches.
tmashuang
reviewed
Nov 28, 2018
danjm
force-pushed
the
new-gas-customize-feature-branch-d
branch
from
ecf439f to
b03c41b
Compare
|
@tmashuang Thanks. I've fixed those now. |
danjm
force-pushed
the
new-gas-customize-feature-branch-d
branch
from
b03c41b to
1cd11bf
Compare
danjm
force-pushed
the
new-gas-customize-feature-branch-d
branch
from
1cd11bf to
9c8fd4d
Compare
danjm
force-pushed
the
new-gas-customize-feature-branch-d
branch
from
9c8fd4d to
0d9f87d
Compare
|
Screen is crowded when Hex Data is enabled, on extension view.
|
|
@tmashuang That issue is fixed
|
danjm
force-pushed
the
new-gas-customize-feature-branch-d
branch
from
92c2e92 to
8194309
Compare
alextsg
approved these changes
Dec 4, 2018
Gudahtt
added a commit
to Gudahtt/metamask-extension
that referenced
this pull request
Jul 25, 2019
The `time-remaining` component hasn't been used since MetaMask#5704, aside from a few styles. Those styles have been integrated into the `advanced-tab-content` styles, and the unused component has been deleted.
Gudahtt
added a commit
that referenced
this pull request
Jul 25, 2019
The `time-remaining` component hasn't been used since #5704, aside from a few styles. Those styles have been integrated into the `advanced-tab-content` styles, and the unused component has been deleted.
Gudahtt
added a commit
to Gudahtt/metamask-extension
that referenced
this pull request
Sep 18, 2019
Gudahtt
added a commit
to Gudahtt/metamask-extension
that referenced
this pull request
Sep 18, 2019
This modal hasn't been used since MetaMask#5704, where it was replaced.
Gudahtt
added a commit
that referenced
this pull request
Sep 18, 2019
This modal hasn't been used since #5704, where it was replaced.
DDDDDanica
pushed a commit
that referenced
this pull request
Apr 24, 2025
## **Description** Cherry-pick of #32237 for `12.17.0`. Creating manual PR as controller patch required for `@metamask/transaction-controller`. Patch changes are a cherry-pick of [#5704](MetaMask/core#5704) and built from [patch/transaction-controller-extension-12-17-0](https://github.com/MetaMask/core/tree/patch/transaction-controller-extension-12-17-0). [](https://codespaces.new/MetaMask/metamask-extension/pull/32238?quickstart=1) ## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/32238?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for final QA