test: Migrate setting-general e2e test to Typescript and POM

[benjisclowder]

Description

Migrating the settings-general e2e test to Typescript and Page Object Model.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-505?atlOrigin=eyJpIjoiMjEwZDhiMjAyNWM0NGUzMWJhNjQxMjhlODBhODhjNDAiLCJwIjoiaiJ9

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [5a477e3]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1234 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1234	1108	1449	64	1267	1348
			load	1067	955	1260	60	1096	1173
			domContentLoaded	1061	950	1253	60	1090	1162
			domInteractive	18	14	69	8	18	29
			firstPaint	758	167	1218	406	1076	1150
			backgroundConnect	7	4	18	2	8	13
			firstReactRender	22	15	62	6	22	32
			getState	13	5	38	7	17	28
			initialActions	0	0	1	0	0	1
			loadScripts	819	719	1014	57	845	918
			setupStore	8	4	33	4	8	13
	Webpack	Home	uiStartup	2096	1713	2486	186	2228	2350
			load	1615	1335	2034	150	1753	1826
			domContentLoaded	1607	1328	1887	146	1747	1819
			domInteractive	16	11	53	9	14	45
			firstPaint	171	68	335	59	193	302
			backgroundConnect	26	12	164	19	26	61
			firstReactRender	210	55	373	122	329	364
			getState	15	4	335	33	14	32
			initialActions	3	1	8	1	3	5
			loadScripts	1602	1325	1882	146	1745	1815
			setupStore	16	7	47	7	20	31
Firefox	Browserify	Home	uiStartup	1360	1196	1676	111	1439	1596
			load	1206	1013	1554	101	1267	1389
			domContentLoaded	1205	1013	1553	101	1266	1388
			domInteractive	102	37	252	34	112	176
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	12	156	19	19	50
			firstReactRender	23	19	59	7	23	30
			getState	12	4	203	31	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1185	999	1539	102	1254	1363
			setupStore	10	4	183	24	6	30
	Webpack	Home	uiStartup	1548	1377	1927	125	1603	1850
			load	1325	1178	1697	113	1390	1596
			domContentLoaded	1324	1177	1696	113	1390	1596
			domInteractive	87	58	268	27	97	130
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	46	6	23	36
			firstReactRender	36	29	52	4	37	44
			getState	9	4	32	5	10	17
			initialActions	0	0	2	1	1	1
			loadScripts	1306	1158	1682	114	1373	1578
			setupStore	11	5	274	27	8	15

Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 30 exceeds gate value 27 for firefox browserify home p95 setupStore
Sum of mean exceeds: 4ms | Sum of p95 exceeds: 3ms
Sum of all benchmark exceeds: 7ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: -998 Bytes (-0.02%)
• ui: 732 Bytes (0.01%)
• common: 1.07 KiB (0.01%)