feat: Add RandomisedEstimationsGasFeeFlow to gas fee flows
#5511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGPoyraz
force-pushed
the
ogp/4446
branch
3 times, most recently
from
6937e70 to
f7b5e4e
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
packages/transaction-controller/src/gas-flows/RandomisedEstimationsGasFeeFlow.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/gas-flows/RandomisedEstimationsGasFeeFlow.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/gas-flows/RandomisedEstimationsGasFeeFlow.ts
Outdated
Show resolved
Hide resolved
matthewwalsh0
requested changes
Mar 20, 2025
matthewwalsh0
requested changes
Mar 20, 2025
packages/transaction-controller/src/gas-flows/RandomisedEstimationsGasFeeFlow.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/gas-flows/RandomisedEstimationsGasFeeFlow.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/gas-flows/RandomisedEstimationsGasFeeFlow.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/gas-flows/RandomisedEstimationsGasFeeFlow.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/gas-flows/RandomisedEstimationsGasFeeFlow.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/gas-flows/RandomisedEstimationsGasFeeFlow.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/gas-flows/RandomisedEstimationsGasFeeFlow.test.ts
Outdated
Show resolved
Hide resolved
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
pedronfigueiredo
previously approved these changes
Mar 25, 2025
matthewwalsh0
requested changes
Mar 26, 2025
packages/transaction-controller/src/gas-flows/RandomisedEstimationsGasFeeFlow.ts
Show resolved
Hide resolved
packages/transaction-controller/src/gas-flows/RandomisedEstimationsGasFeeFlow.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/gas-flows/RandomisedEstimationsGasFeeFlow.ts
Outdated
Show resolved
Hide resolved
OGPoyraz
commented
Mar 27, 2025
matthewwalsh0
requested changes
Mar 27, 2025
packages/transaction-controller/src/gas-flows/RandomisedEstimationsGasFeeFlow.ts
Outdated
Show resolved
Hide resolved
pedronfigueiredo
approved these changes
Mar 27, 2025
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
matthewwalsh0
approved these changes
Mar 28, 2025
| gasFeeRandomisation.preservedNumberOfDigits ?? | ||
| DEFAULT_PRESERVE_NUMBER_OF_DIGITS; | ||
|
|
||
| if (gasEstimateType === GAS_ESTIMATE_TYPES.FEE_MARKET) { |
There was a problem hiding this comment.
Minor, could we also ignore the gasFeeControllerData entirely and just mutate the result of getDefaultGasFees?
That would avoid needed to convert from the GasFeeController format.
There was a problem hiding this comment.
My initial thinking was that.
Essentially both will result same, I tried to avoid doing that to do more changes in randomiseDecimalGWEIAndConvertToHex function since this is already manually tested and timeframe is tight. But I agree it could save some steps already done in default flow.
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
14 tasks
MajorLift
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 1, 2025
Cherry-pick: #31335 This introduces three high-priority core repo PRs in this release: - MetaMask/core#5511 - MetaMask/core#5549 - MetaMask/core#5552 --- // --- Fix balance change simulation of type-4 transactions by bumping `@metamask/transaction-controller` to `52.3.0`. [](https://codespaces.new/MetaMask/metamask-extension/pull/31335?quickstart=1) Fixes: [#4506](MetaMask/MetaMask-planning#4506) - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/31440?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: Matthew Walsh <[email protected]>
](https://codespaces.new/MetaMask/metamask-extension/pull/31335?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/31440?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR aims to add
RandomisedEstimationsGasFeeFlowto gas fee flows inTransactionController.Depending on the remote feature flags,
RandomisedEstimationsGasFeeFlowrandomises the last digits of given estimations. To see exact randomisation it is happeningrandomiseDecimalValueAndConvertToHexfunction in theRandomisedEstimationsGasFeeFlow.tsfile. Also in case of any error this gas fee flow will default toDefaultGasFeeFlow.References
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4446
randomised.gas.values.mov
Changelog
@metamask/transaction-controllerRandomisedEstimationsGasFeeFlowto gas fee flows inTransactionControllerchainIdis defined in feature flags.Checklist