Don't include private packages in public areas (#4112)

Don't consider workspace packages marked as private when:

- Generating docs
- Compiling TypeScript into JavaScript for publishing purposes (either
locally or on CI)
- Note that TypeScript code in private packages will still be
typechecked locally, though.
- Updating changelogs
- Updating the diagram or list of packages in the README
- Publishing releases (either preview builds or regular releases)

This allows us to create an example controller package in `packages`
that is purely local to this repo.

Author: mcmire

.github/workflows/lint-build-test.yml

@@ -23,7 +23,7 @@ jobs:
       - name: Fetch workspace package names
         id: workspace-package-names
         run: |
-          echo "child-workspace-package-names=$(yarn child-workspace-package-names-as-json)" >> "$GITHUB_OUTPUT"
+          echo "child-workspace-package-names=$(yarn workspaces list --no-private --json | jq --slurp --raw-output 'map(.name) | @json')" >> "$GITHUB_OUTPUT"
         shell: bash
 
   lint:

package.json

@@ -14,13 +14,12 @@
   "scripts": {
     "build": "yarn run build:source && yarn run build:types",
     "build:clean": "rimraf dist '**/*.tsbuildinfo' && yarn build",
-    "build:docs": "yarn workspaces foreach --parallel --interlaced --verbose run build:docs",
-    "build:source": "yarn workspaces foreach --exclude @metamask/core-monorepo --parallel --interlaced --verbose run build",
+    "build:docs": "yarn workspaces foreach --no-private --parallel --interlaced --verbose run build:docs",
+    "build:source": "yarn workspaces foreach --no-private --parallel --interlaced --verbose run build",
     "build:types": "tsc --build tsconfig.build.json --verbose",
     "build:watch": "yarn run build --watch",
-    "changelog:update": "yarn workspaces foreach --parallel --interlaced --verbose run changelog:update",
-    "changelog:validate": "yarn workspaces foreach --parallel --interlaced --verbose run changelog:validate",
-    "child-workspace-package-names-as-json": "ts-node scripts/child-workspace-package-names-as-json.ts",
+    "changelog:update": "yarn workspaces foreach --no-private --parallel --interlaced --verbose run changelog:update",
+    "changelog:validate": "yarn workspaces foreach --no-private --parallel --interlaced --verbose run changelog:validate",
     "create-package": "ts-node scripts/create-package",
     "lint": "yarn lint:eslint && yarn lint:misc --check && yarn constraints && yarn lint:dependencies",
     "lint:dependencies": "depcheck && yarn dedupe --check",
@@ -30,7 +29,7 @@
     "lint:misc": "prettier '**/*.json' '**/*.md' '!**/CHANGELOG.old.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path .gitignore",
     "prepack": "./scripts/prepack.sh",
     "prepare-preview-builds": "./scripts/prepare-preview-builds.sh",
-    "publish-previews": "yarn workspaces foreach --parallel --verbose run publish:preview",
+    "publish-previews": "yarn workspaces foreach --no-private --parallel --verbose run publish:preview",
     "setup": "yarn install",
     "test": "yarn test:scripts --silent --collectCoverage=false --reporters=jest-silent-reporter && yarn test:packages",
     "test:clean": "yarn workspaces foreach --parallel --verbose run test:clean && yarn test",

scripts/child-workspace-package-names-as-json.ts

@@ -52,6 +52,7 @@ async function retrieveWorkspaces(): Promise<Workspace[]> {
     'workspaces',
     'list',
     '--json',
+    '--no-private',
     '--verbose',
   ]);