Skip to content

Commit 3ed5af7

Browse files
legobeatadonesky1
authored andcommitted
fix(gas-fee-controller): add missing @metamask/polling-controller (#1748)
## Explanation Adds missing dependency introduced in #1673 ## References - Follow-up to: #1673 ## Changelog ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Alex <[email protected]>
1 parent 3ee8a6d commit 3ed5af7

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

constraints.pro

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,14 +298,15 @@ gen_enforced_dependency(WorkspaceCwd, DependencyIdent, null, DependencyType) :-
298298
workspace_has_dependency(WorkspaceCwd, DependencyIdent, DependencyRange, DependencyType),
299299
DependencyType == 'devDependencies'.
300300

301-
% If a controller dependency (other than `base-controller` and
302-
% `eth-keyring-controller`) is listed under "dependencies", it should also be
301+
% If a controller dependency (other than `base-controller`, `eth-keyring-controller` and
302+
% `polling-controller`) is listed under "dependencies", it should also be
303303
% listed under "peerDependencies". Each controller is a singleton, so we need
304304
% to ensure the versions used match expectations.
305305
gen_enforced_dependency(WorkspaceCwd, DependencyIdent, DependencyRange, 'peerDependencies') :-
306306
workspace_has_dependency(WorkspaceCwd, DependencyIdent, DependencyRange, 'dependencies'),
307307
DependencyIdent \= '@metamask/base-controller',
308308
DependencyIdent \= '@metamask/eth-keyring-controller',
309+
DependencyIdent \= '@metamask/polling-controller',
309310
is_controller(DependencyIdent).
310311

311312
% All packages must specify a minimum Node version of 16.

packages/gas-fee-controller/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
"@metamask/controller-utils": "^5.0.1",
3434
"@metamask/eth-query": "^3.0.1",
3535
"@metamask/network-controller": "^13.0.1",
36+
"@metamask/polling-controller": "^0.0.0",
3637
"@metamask/utils": "^8.1.0",
3738
"@types/uuid": "^8.3.0",
3839
"ethereumjs-util": "^7.0.10",

yarn.lock

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1807,6 +1807,7 @@ __metadata:
18071807
"@metamask/controller-utils": ^5.0.1
18081808
"@metamask/eth-query": ^3.0.1
18091809
"@metamask/network-controller": ^13.0.1
1810+
"@metamask/polling-controller": ^0.0.0
18101811
"@metamask/utils": ^8.1.0
18111812
"@types/jest": ^27.4.1
18121813
"@types/jest-when": ^2.7.3
@@ -2120,7 +2121,7 @@ __metadata:
21202121
languageName: unknown
21212122
linkType: soft
21222123

2123-
"@metamask/polling-controller@workspace:packages/polling-controller":
2124+
"@metamask/polling-controller@^0.0.0, @metamask/polling-controller@workspace:packages/polling-controller":
21242125
version: 0.0.0-use.local
21252126
resolution: "@metamask/polling-controller@workspace:packages/polling-controller"
21262127
dependencies:

0 commit comments

Comments
 (0)