Fix quoting of schema name (#54) (#100)

* function that adds quotes to schema name if the schema name contains upper case letter

* needs string with " if upper case letters, psycopg2 takes care of adding '

* add workspace

* parametrize tests, so that they run on two project names - adding problematic project name with upper case letter

* add test info about workspace

* update test name

* fix tests to properly escape schema names

* add to avoid accidental commits

* escape if schema contains other characters then a-z 0-9 and _, use double quote if necessary

* rename tests to avoid potential issues on Windows

* do not parameterize all the tests

* create simple parametrized test, that contains just init, push and pull for couple of different project names

---------

Co-authored-by: Jan Caha <[email protected]>

Author: JanCaha

.gitignore

@@ -4,3 +4,5 @@ config.ini
 mergin
 .coverage
 htmlcov
+.vscode
+.env

README.md

@@ -140,6 +140,7 @@ To run automatic tests:
     export TEST_MERGIN_URL=<url>                # testing server
     export TEST_API_USERNAME=<username>
     export TEST_API_PASSWORD=<pwd>
+    export TEST_API_WORKSPACE=<workspace>
     pytest-3 test/
 
 

dbsync.py

@@ -16,6 +16,7 @@
 import tempfile
 import random
 import uuid
+import re
 
 import psycopg2
 from itertools import chain
@@ -34,6 +35,14 @@ class DbSyncError(Exception):
     pass
 
 
+def _add_quotes_to_schema_name(schema: str) -> str:
+    matches = re.findall(r"[^a-z0-9_]", schema)
+    if len(matches) != 0:
+        schema = schema.replace("\"", "\"\"")
+        schema = f'"{schema}"'
+    return schema
+
+
 def _tables_list_to_string(tables):
     return ";".join(tables)
 
@@ -230,6 +239,7 @@ def _set_db_project_comment(conn, schema, project_name, version, project_id=None
 def _get_db_project_comment(conn, schema):
     """ Get Mergin Maps project name and its current version in db schema"""
     cur = conn.cursor()
+    schema = _add_quotes_to_schema_name(schema)
     cur.execute("SELECT obj_description(%s::regnamespace, 'pg_namespace')", (schema, ))
     res = cur.fetchone()[0]
     try: