Skip to content

Fix up linting errors found by the new js-lint #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

Fix up linting errors found by the new js-lint #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d86ecee
fix: removed unreachable conditional branches
CDeltakai May 14, 2025
e557461
fix: ensure waitPs.reverse() explicitly discards the returned array w…
CDeltakai May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/LockBox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ class LockBox<L extends Lockable = Lockable> implements Lockable {
signal.addEventListener(
'abort',
() => {
waitPs.reverse();
void waitPs.reverse();
for (const waitP of waitPs) {
waitP.cancel(signal.reason);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Monitor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ class Monitor<RWLock extends RWLockReader | RWLockWriter> implements Lockable {
signal.addEventListener(
'abort',
() => {
waitPs.reverse();
void waitPs.reverse();
for (const waitP of waitPs) {
waitP.cancel(signal.reason);
}
Expand Down
4 changes: 0 additions & 4 deletions src/RWLockReader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,6 @@ class RWLockReader implements Lockable {
} else {
if (typeof params[0] === 'string') {
type = params.shift() as 'read' | 'write';
} else if (typeof params[0] == null) {
params.shift();
}
}
type = type! ?? 'write';
Expand Down Expand Up @@ -268,8 +266,6 @@ class RWLockReader implements Lockable {
} else {
if (typeof params[0] === 'string') {
type = params.shift() as 'read' | 'write';
} else if (typeof params[0] == null) {
params.shift();
}
}
type = type! ?? 'write';
Expand Down
4 changes: 0 additions & 4 deletions src/RWLockWriter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,6 @@ class RWLockWriter implements Lockable {
} else {
if (typeof params[0] === 'string') {
type = params.shift() as 'read' | 'write';
} else if (typeof params[0] == null) {
params.shift();
}
}
type = type! ?? 'write';
Expand Down Expand Up @@ -269,8 +267,6 @@ class RWLockWriter implements Lockable {
} else {
if (typeof params[0] === 'string') {
type = params.shift() as 'read' | 'write';
} else if (typeof params[0] == null) {
params.shift();
}
}
type = type! ?? 'write';
Expand Down