Skip to content

Commit 03c3260

Browse files
authored
Merge pull request #9671 from Fryguy/node_version_file
Read the node version from package.json in CI
2 parents e477ee1 + 68d0e09 commit 03c3260

File tree

4 files changed

+6
-9
lines changed

4 files changed

+6
-9
lines changed

.github/workflows/ci.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ jobs:
2020
ruby-version:
2121
- '3.1'
2222
- '3.3'
23-
node-version:
24-
- 20
2523
test-suite:
2624
- spec
2725
- spec:compile
@@ -61,7 +59,7 @@ jobs:
6159
|| matrix.test-suite == 'spec:jest' }}"
6260
uses: actions/setup-node@v5
6361
with:
64-
node-version: "${{ matrix.node-version }}"
62+
node-version-file: package.json
6563
cache: yarn
6664
registry-url: https://npm.manageiq.org/
6765
- name: Prepare tests

.github/workflows/cypress.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ jobs:
2020
matrix:
2121
ruby-version:
2222
- '3.3'
23-
node-version:
24-
- 20
2523
cypress-browser:
2624
- chrome
2725
- firefox
@@ -67,8 +65,9 @@ jobs:
6765
uses: actions/setup-node@v5
6866
if: ${{ env.RUN_CYPRESS == 'true' }}
6967
with:
70-
node-version: "${{ matrix.node-version }}"
68+
node-version-file: package.json
7169
cache: yarn
70+
registry-url: https://npm.manageiq.org/
7271
- name: Prepare tests
7372
run: bin/setup
7473
if: ${{ env.RUN_CYPRESS == 'true' }}

.github/workflows/yarn_lock.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
- name: Set up Node
1616
uses: actions/setup-node@v5
1717
with:
18-
node-version: "20"
18+
node-version-file: package.json
1919
cache: yarn
2020
registry-url: https://npm.manageiq.org/
2121
- name: Update yarn.lock

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,8 @@
176176
"webpack-stats-plugin": "^0.3.2"
177177
},
178178
"engines": {
179-
"node": ">= 20.19.5",
180-
"npm": ">= 10.8.2"
179+
"node": "^20.19.5",
180+
"npm": "^10.8.2"
181181
},
182182
"packageManager": "[email protected]",
183183
"resolutions": {

0 commit comments

Comments
 (0)