Merge pull request #26 from AzCiS/onesdk-p2-sumanths

Bug fix: allow rename of entities

Author: avirupch

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/BackupPolicy/SetAzureStorSimpleDeviceBackupPolicy.cs

@@ -58,6 +58,10 @@ public class SetAzureStorSimpleDeviceBackupPolicy: StorSimpleCmdletBase
         [Parameter(Position = 7, Mandatory = false, HelpMessage = StorSimpleCmdletHelpMessage.WaitTillComplete)]
         public SwitchParameter WaitForComplete { get; set; }
 
+        [Parameter(Position = 8, Mandatory = false, HelpMessage = StorSimpleCmdletHelpMessage.BackupPolicyNewName)]
+        [ValidateNotNullOrEmpty]
+        public string NewName { get; set; }
+
         private string deviceId = null;
         private List<BackupScheduleBase> schedulesToAdd = null;
         private List<BackupScheduleUpdateRequest> schedulesToUpdate = null;
@@ -74,7 +78,7 @@ public override void ExecuteCmdlet()
                     return;
 
                 updateConfig.InstanceId = BackupPolicyId;
-                updateConfig.Name = BackupPolicyName;
+                updateConfig.Name = (NewName != null ? NewName : BackupPolicyName);
                 updateConfig.IsPolicyRenamed = true;
                 updateConfig.BackupSchedulesToBeAdded = schedulesToAdd;
                 updateConfig.BackupSchedulesToBeUpdated = schedulesToUpdate;

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/ServiceConfig/SetAzureStorSimpleAccessControlRecord.cs

@@ -41,6 +41,10 @@ public class SetAzureStorSimpleAccessControlRecord : StorSimpleCmdletBase
         [Parameter(Position = 2, Mandatory = false, HelpMessage = StorSimpleCmdletHelpMessage.WaitTillComplete)]
         public SwitchParameter WaitForComplete { get; set; }
 
+        [Parameter(Position = 3, Mandatory = false, HelpMessage = StorSimpleCmdletHelpMessage.ACRNewName)]
+        [ValidateNotNullOrEmpty]
+        public string NewName { get; set; }
+
         public override void ExecuteCmdlet()
         {
             try
@@ -67,7 +71,7 @@ public override void ExecuteCmdlet()
                                 GlobalId = existingAcr.GlobalId,
                                 InitiatorName = IQNInitiatorName,
                                 InstanceId = existingAcr.InstanceId,
-                                Name = existingAcr.Name,
+                                Name = (!string.IsNullOrWhiteSpace(NewName) ? NewName : existingAcr.Name),
                                 VolumeCount = existingAcr.VolumeCount
                             },
                         }

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/Volume/SetAzureStorSimpleDeviceVolume.cs

@@ -54,6 +54,10 @@ public class SetAzureStorSimpleDeviceVolume : StorSimpleCmdletBase
         [Parameter(Position = 6, Mandatory = false, HelpMessage = StorSimpleCmdletHelpMessage.WaitTillComplete)]
         public SwitchParameter WaitForComplete { get; set; }
 
+        [Parameter(Position = 7, Mandatory = false, HelpMessage = StorSimpleCmdletHelpMessage.VolumeNewName)]
+        [ValidateNotNullOrEmpty]
+        public string NewName { get; set; }
+
         public override void ExecuteCmdlet()
         {
             try
@@ -91,11 +95,16 @@ public override void ExecuteCmdlet()
                     diskDetails.AcrList = AccessControlRecords;
                 }
 
+                if (!string.IsNullOrWhiteSpace(NewName))
+                {
+                    diskDetails.Name = NewName;
+                }
+
                 if (WaitForComplete.IsPresent)
                 {
                     var taskstatus = StorSimpleClient.UpdateVolume(deviceId, diskDetails.InstanceId, diskDetails);
                     HandleSyncTaskResponse(taskstatus, "update");
-                    var updatedVolume = StorSimpleClient.GetVolumeByName(deviceId, VolumeName);
+                    var updatedVolume = StorSimpleClient.GetVolumeByName(deviceId, diskDetails.Name);
                     WriteObject(updatedVolume.VirtualDiskInfo);
                 }
                 else

src/ServiceManagement/StorSimple/Commands.StorSimple/StorSimpleCmdletHelpMessage.cs

@@ -18,6 +18,7 @@ namespace Microsoft.WindowsAzure.Commands.StorSimple
     internal static class StorSimpleCmdletHelpMessage
     {
         public const string ACRName = "The access control record name.";
+        public const string ACRNewName = "The new name for the access control record";
         public const string ACRObject = "The access control record object.";
         public const string DataContainerBandwidth = "The data container bandwidth rate.";
         public const string DataContainerEncryptionEnabled = "Flag to encrypt the data container.";
@@ -46,6 +47,7 @@ internal static class StorSimpleCmdletHelpMessage
         public const string VolumeName = "The volume name.";
         public const string VolumeOnline = "Is the volume online";
         public const string VolumeSize = "The size of volume in bytes.";
+        public const string VolumeNewName = "The new name for the volume";
         public const string WaitTillComplete = "Wait till the async operation completes.";
         public const string BackupPolicyName = "Name of the Backup policy that you wish to retrieve. Skip this parameter to get all policies";
         public const string BackupIdToDelete = "InstanceId of the Backup that needs to be deleted";
@@ -78,6 +80,7 @@ internal static class StorSimpleCmdletHelpMessage
         public const string BackupScheduleBaseObjsToAdd = "List of BackupScheduleBase objects to be added to the policy";
         public const string BackupScheduleBaseObjsToUpdate = "List of BackupScheduleUpdateRequest objects to be updated";
         public const string BackupScheduleBaseObjsToDelete = "List of Instance Id of BackupSchedule objects to be deleted";
+        public const string BackupPolicyNewName = "The new name for the backup policy";
         public const string VolumeObjsToUpdate = "List of VolumeIds to be updated";
         public const string ResourceName = "Name of the resource which needs to be retrieved";
         public const string SourceDeviceId = "The device identifier of the source device";