Remove requirements.txt; expand workflows to include Python 3.9/3.10 #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 12, 2022 16:41
Having the file 'requirements.txt' implies that there is a particular set of external package versions that are recommended, if not required. That's not true; all of the packages that wfdb-python requires are quite stable and any vaguely recent version will do, and you should generally be using the most up-to-date version that is compatible with your application requirements. Moreover, there's no specific set of external package version numbers that works across all platforms we might want to test. Therefore, remove the file requirements.txt, and for purposes of *testing*, use whatever pip selects by default.
Expand the set of automated tests to include the newest Python versions that GitHub supports. These numbers must be quoted to interpret them as strings rather than numbers. Way to go, yaml.
shrug |
cx1111
approved these changes
Apr 13, 2022
|
Make sure no info is being lost from here, since people have had to manually keep this and setup.py in sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including a "requirements.txt" (or equivalent) in the repository likely suggests to users that those are the specific package versions they need to use. That's not true.
Indeed, as this package is intended in part as a general-purpose library for applications to use (not just an application in and of itself), it's important that this package doesn't impose unnecessary limits on what other libraries may be co-installed with it.
So for testing purposes, it would be better to actually test a variety of different yet stable package versions. 'test-deb10-i386' is a start at doing that. But in lieu of that, we should at least try to test "the latest thing available from pypi" across a variety of interpreter versions.
You may think this makes test-suite runs less reproducible... which is true. But they weren't really reproducible anyway because pip would install a whole bunch of indirect dependencies automatically. If we need to reproduce a test-suite run, we can do so (or try to) by extracting the list of installed versions from the log.