-
Notifications
You must be signed in to change notification settings - Fork 313
Switch to Poetry for dependency management and package description #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
eac1e54
Add poetry configuration file and update project dependencies
cx1111 832d1b1
Update package description and patch version. Remove version.py file
cx1111 d8590da
Remove requirements.txt, setup.py, and MANIFEST.in. Update GH Actions…
cx1111 aebb215
Merge branch 'master' into cx/poetry
cx1111 e3be731
Add Sphinx to dev dependencies
cx1111 3590737
Remove old __version__ variable
cx1111 d326a13
Update contact email. Correct python version matrix and bump debian c…
cx1111 4c89ddb
Correct poetry install command in actions
cx1111 fda67a3
Update nosetest call
cx1111 7fb2539
Debug test
cx1111 c0d3a3e
Debug test
cx1111 bb5a8aa
Update dependencies to working set with Python 3.7
cx1111 e3ab58c
Add installation notes
cx1111 36bbf04
Update CI python-version to include 3.7
cx1111 d32b56e
Reset Actions to use debian 10
cx1111 ac1d9a7
Restore version file
cx1111 e93046d
Lower min dependency versions
cx1111 674827f
Revert install instructions
cx1111 215bf79
Add requests
cx1111 2864f7b
Merge branch 'master' into cx/poetry
cx1111 3869ec8
Update actions file
cx1111 57d4ee3
Try calling nose with python
cx1111 c653d67
Try separate command
cx1111 6643046
Replace nose with pytest
cx1111 d0c8a40
Do not install wfdb for dept install action
cx1111 e062b0c
Test
cx1111 8961b5f
Use optional for dev dependencies. Use pip instead of poetry for CI
cx1111 f3616b9
Correct escaping
cx1111 a9564e0
Tighten Python versions and update developer docs
cx1111 d90a1f3
Restore Python compat versions
cx1111 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,3 +69,6 @@ target/ | |
|
||
# OSX .DS_Store | ||
.DS_Store | ||
|
||
# pyenv | ||
.python-version |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're using pip to install the dependencies instead of poetry for a few reasons:
poetry install
would install the packages (including the test executable) into~/.cache
which weren't automatically usable by the system installed Python (causing all those test failures). We don't need to deal with this.