Skip to content

fixes mypy errors in trainer/supporters.py #14633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 12, 2022
Merged

fixes mypy errors in trainer/supporters.py #14633

merged 17 commits into from
Sep 12, 2022

Conversation

donlapark
Copy link
Contributor

What does this PR do?

Fixes mypy errors in pytorch_lightning/trainer/supporters.py for issue #13445

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 10, 2022
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! Minor comments on my side, but otherwise LGTM

@awaelchli awaelchli added code quality community This PR is from the community labels Sep 10, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 10, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 11, 2022
@Borda Borda merged commit f49c2e3 into Lightning-AI:master Sep 12, 2022
@donlapark donlapark deleted the type_fix_supporters_py branch September 12, 2022 17:27
@otaj otaj mentioned this pull request Sep 13, 2022
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants