Skip to content

Fix mypy errors attributed to pytorch_lightning. strategies.sharded_spawn #14102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 11, 2022
Merged

Fix mypy errors attributed to pytorch_lightning. strategies.sharded_spawn #14102

merged 11 commits into from
Aug 11, 2022

Conversation

krishnakalyan3
Copy link
Contributor

Part of #13445

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 8, 2022
@krishnakalyan3 krishnakalyan3 changed the title Fix mypy errors attributed to pytorch_lightning. strategies. sharded_spawn Fix mypy errors attributed to pytorch_lightning. strategies.sharded_spawn Aug 8, 2022
@krishnakalyan3 krishnakalyan3 changed the title Fix mypy errors attributed to pytorch_lightning. strategies.sharded_spawn Fix mypy errors attributed to pytorch_lightning. strategies.sharded_spawn Aug 8, 2022
@otaj otaj mentioned this pull request Aug 9, 2022
52 tasks
@rohitgr7 rohitgr7 added this to the pl:1.8 milestone Aug 9, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 10, 2022
@Borda Borda enabled auto-merge (squash) August 10, 2022 15:25
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #14102 (833d4ac) into master (9b61b1c) will increase coverage by 25%.
The diff coverage is 100%.

❗ Current head 833d4ac differs from pull request most recent head 775a8aa. Consider uploading reports for the commit 775a8aa to get more accurate results

@@            Coverage Diff            @@
##           master   #14102     +/-   ##
=========================================
+ Coverage      51%      76%    +25%     
=========================================
  Files         326      326             
  Lines       26565    26657     +92     
=========================================
+ Hits        13626    20260   +6634     
+ Misses      12939     6397   -6542     

auto-merge was automatically disabled August 11, 2022 08:05

Head branch was pushed to by a user without write access

@awaelchli awaelchli enabled auto-merge (squash) August 11, 2022 15:21
@awaelchli awaelchli merged commit e53c4e8 into Lightning-AI:master Aug 11, 2022
jessecambon pushed a commit to jessecambon/lightning that referenced this pull request Aug 16, 2022
…spawn` (Lightning-AI#14102)


Co-authored-by: rohitgr7 <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: awaelchli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants