Skip to content

Fix mypy typing errors attributed to pytorch_lightning/demos/mnist_datamodule.py #13929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 18, 2022
Merged

Fix mypy typing errors attributed to pytorch_lightning/demos/mnist_datamodule.py #13929

merged 13 commits into from
Aug 18, 2022

Conversation

uhhyunjoo
Copy link
Contributor

What does this PR do?

Fixes mypy typing errors in pytorch_lightning/demos/mnist_datamodule.py in #13445.

Does your PR introduce any breaking changes? If yes, please list them.

None. just fixed typing errors.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃 → Yep! 😊

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 29, 2022
@otaj otaj mentioned this pull request Jul 29, 2022
Closed
52 tasks
otaj
otaj approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@otaj otaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left couple comments, but overall it looks good :) Thank you!

@otaj otaj added this to the pl:1.7.x milestone Aug 2, 2022
rohitgr7
rohitgr7 reviewed Aug 3, 2022
View reviewed changes
@mergify mergify bot added the has conflicts label Aug 3, 2022
@awaelchli awaelchli modified the milestones: pl:1.7.x, pl:1.8 Aug 12, 2022
@awaelchli
Copy link
Contributor

@otaj @rohitgr7 I addressed your reviews

@mergify mergify bot removed the has conflicts label Aug 18, 2022
@mergify mergify bot added ready PRs ready to be merged and removed ready PRs ready to be merged labels Aug 18, 2022
rohitgr7
rohitgr7 approved these changes Aug 18, 2022
View reviewed changes
@otaj otaj enabled auto-merge (squash) August 18, 2022 11:52
@otaj otaj merged commit e64a4c3 into Lightning-AI:master Aug 18, 2022
nicolai86 pushed a commit that referenced this pull request Aug 23, 2022
@uhhyunjoo @awaelchli
@rohitgr7 @nicolai86
Fix mypy typing errors attributed to `pytorch_lightning/demos/mnist_d…
b2fd620 
…atamodule.py` (#13929)

Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
otaj pushed a commit that referenced this pull request Aug 26, 2022
followup to #13929
8a03678
@otaj otaj mentioned this pull request Aug 26, 2022
Merged
12 tasks
justusschock pushed a commit that referenced this pull request Aug 26, 2022
@otaj
Remove appropriate line from pyproject.toml as a followup to #13929 (…
c418828 
…#14397)

followup to #13929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@otaj otaj otaj approved these changes

@carmocca carmocca carmocca approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees
No one assigned
Labels
pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
5 participants
@uhhyunjoo @awaelchli @otaj @carmocca @rohitgr7