-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix mypy typing errors in pytorch_lightning.utilities.data.py #13901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@nandwalritik @otaj, mind checking the conflicts 🦦 |
Hi, @nandwalritik, do you intend to keep working on this? If not, I can take it over the finish line ⚡ |
let's take it over, pls 🐰 |
Sorry got busy with office work, you can take it over @otaj . |
@Borda It should be finished now, ready for review. |
@otaj Thank you, and sorry for the merge conflicts when ripping apart some of these utilities. I hope it wasn't too annoying. |
Codecov Report
@@ Coverage Diff @@
## master #13901 +/- ##
=========================================
+ Coverage 85% 86% +2%
=========================================
Files 381 264 -117
Lines 27633 20035 -7598
=========================================
- Hits 23372 17299 -6073
+ Misses 4261 2736 -1525 |
What does this PR do?
Fix mypy errors attributed to pytorch_lightning.utilities.data.py for issue #13445
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Yeah