Skip to content

Fix mypy typing errors in pytorch_lightning/strategies/tpu_spawn.py #13813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Aug 2, 2022
Merged

Fix mypy typing errors in pytorch_lightning/strategies/tpu_spawn.py #13813

merged 23 commits into from
Aug 2, 2022

Conversation

Jungwon-Lee
Copy link
Contributor

@Jungwon-Lee Jungwon-Lee commented Jul 23, 2022 •
edited
Loading

What does this PR do?

Fix typing errors in pytorch_lightning/strategies/tpu_spawn.py in issue #13445.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 23, 2022
Jungwon-Lee
Jungwon-Lee commented Jul 23, 2022
View reviewed changes
@mergify mergify bot removed the has conflicts label Jul 23, 2022
@codecov
Copy link

codecov bot commented Jul 23, 2022 •
edited
Loading

Codecov Report

Merging #13813 (3ee844e) into master (eb233ea) will increase coverage by 0%.
The diff coverage is 92%.

@@           Coverage Diff           @@
##           master   #13813   +/-   ##
=======================================
  Coverage      76%      76%           
=======================================
  Files         335      335           
  Lines       26368    26378   +10     
=======================================
+ Hits        20137    20145    +8     
- Misses       6231     6233    +2

awaelchli
awaelchli reviewed Jul 24, 2022
View reviewed changes
@Jungwon-Lee Jungwon-Lee force-pushed the typing_tpu_spawn branch 4 times, most recently from ec47773 to afb1847 Compare July 25, 2022 05:16
@otaj otaj mentioned this pull request Jul 25, 2022
Closed
52 tasks
@otaj
Copy link
Contributor

otaj commented Jul 26, 2022

For some reason, mypy seems to have some trouble with self._checkpoint_io (line 79), which should not be happening. I would honestly consider it a mypy bug. However, there are also other failing tests

@awaelchli awaelchli added the accelerator: tpu Tensor Processing Unit label Jul 27, 2022
carmocca
carmocca reviewed Jul 28, 2022
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mypy job is failing

@carmocca carmocca modified the milestones: pl:0.8.x, pl:1.8 Jul 28, 2022
rohitgr7
rohitgr7 previously approved these changes Jul 28, 2022
View reviewed changes
@rohitgr7 rohitgr7 dismissed their stale review July 28, 2022 19:11

one more round

@otaj
Copy link
Contributor

otaj commented Jul 29, 2022

I took the liberty of solving the mypy errors regarding self._checkpoint_io

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 1, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 2, 2022
@otaj otaj modified the milestones: pl:1.8, pl:1.7.x Aug 2, 2022
@otaj otaj enabled auto-merge (squash) August 2, 2022 07:45
@otaj otaj merged commit d8e5e7f into Lightning-AI:master Aug 2, 2022
@awaelchli awaelchli modified the milestones: pl:1.7.x, pl:1.7 Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca left review comments

@Borda Borda Borda approved these changes

@otaj otaj otaj approved these changes

@rohitgr7 rohitgr7 rohitgr7 left review comments

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
accelerator: tpu Tensor Processing Unit code quality community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@Jungwon-Lee @otaj @awaelchli @Borda @carmocca @rohitgr7