-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix mypy errors attributed to pytorch_lightning.trainer.connectors.data_connector.py
#13806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
otaj
merged 55 commits into
Lightning-AI:master
from
jxtngx:codeq/trainer-dataconnector
Aug 26, 2022
Merged
Fix mypy errors attributed to pytorch_lightning.trainer.connectors.data_connector.py
#13806
otaj
merged 55 commits into
Lightning-AI:master
from
jxtngx:codeq/trainer-dataconnector
Aug 26, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 tasks
jxtngx
commented
Jul 23, 2022
jxtngx
commented
Jul 23, 2022
jxtngx
commented
Jul 23, 2022
otaj
reviewed
Jul 25, 2022
@JustinGoheen, we're sorry to hear that. @rohitgr7, are you gonna push it over the finish line or should I? I noticed you started pushing some commits ⚡ |
@otaj it's done. Any things else needs to be done here? The CI is blocking the merge for now |
@rohitgr7, awesome, thank you! 🎉. I guess we just have to wait on codeowners and CI |
carmocca
reviewed
Aug 17, 2022
awaelchli
approved these changes
Aug 18, 2022
justusschock
approved these changes
Aug 22, 2022
carmocca
approved these changes
Aug 22, 2022
Borda
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code quality
community
This PR is from the community
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
trainer: connector
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix mypy errors attributed to
pytorch_lightning.trainer.connectors.data_connector.py
for issue #13445Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list: