Skip to content

Fix mypy errors attributed to pytorch_lightning.trainer.connectors.data_connector.py #13806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 55 commits into from
Aug 26, 2022
Merged

Fix mypy errors attributed to pytorch_lightning.trainer.connectors.data_connector.py #13806

merged 55 commits into from
Aug 26, 2022

Conversation

jxtngx
Copy link
Contributor

@jxtngx jxtngx commented Jul 23, 2022

What does this PR do?

Fix mypy errors attributed to pytorch_lightning.trainer.connectors.data_connector.py for issue #13445

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@jxtngx jxtngx mentioned this pull request Jul 23, 2022
52 tasks
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 23, 2022
@jxtngx jxtngx marked this pull request as ready for review July 23, 2022 16:46
@otaj
Copy link
Contributor

otaj commented Aug 17, 2022

@JustinGoheen, we're sorry to hear that. @rohitgr7, are you gonna push it over the finish line or should I? I noticed you started pushing some commits ⚡

@rohitgr7
Copy link
Contributor

@otaj it's done. Any things else needs to be done here? The CI is blocking the merge for now

@otaj
Copy link
Contributor

otaj commented Aug 17, 2022

@rohitgr7, awesome, thank you! 🎉. I guess we just have to wait on codeowners and CI

@otaj otaj enabled auto-merge (squash) August 17, 2022 09:04
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 21, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Aug 22, 2022
@otaj otaj merged commit 94e567e into Lightning-AI:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged trainer: connector
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants