Skip to content

Fix mypy errors attributed to pytorch_lightning.loggers.neptune #13692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Aug 3, 2022
Merged

Fix mypy errors attributed to pytorch_lightning.loggers.neptune #13692

merged 27 commits into from
Aug 3, 2022

Conversation

jxtngx
Copy link
Contributor

@jxtngx jxtngx commented Jul 17, 2022 •
edited
Loading

What does this PR do?

Fix mypy errors attributed to pytorch_lightning.loggers.neptune for issue #13445

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@jxtngx
Copy link
Contributor Author

jxtngx commented Jul 17, 2022

blocked by #13689 for call to _add_prefix addressed in this diff of linked PR

@otaj otaj mentioned this pull request Jul 18, 2022
Closed
52 tasks
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 23, 2022
@otaj
Copy link
Contributor

otaj commented Jul 27, 2022

blocked by #13689 for call to _add_prefix addressed in this diff of linked PR

Hi @JustinGoheen, #13689 is already merged.

@jxtngx jxtngx marked this pull request as ready for review July 27, 2022 20:01
@codecov
Copy link

codecov bot commented Jul 27, 2022 •
edited
Loading

Codecov Report

Merging #13692 (d9bdbf1) into master (af07e75) will decrease coverage by 10%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #13692     +/-   ##
=========================================
- Coverage      86%      76%    -10%     
=========================================
  Files         341      341             
  Lines       26563    27339    +776     
=========================================
- Hits        22732    20728   -2004     
- Misses       3831     6611   +2780

awaelchli
awaelchli approved these changes Jul 27, 2022
View reviewed changes
@awaelchli awaelchli added this to the pl:1.6.x milestone Jul 27, 2022
@jxtngx jxtngx marked this pull request as draft July 27, 2022 22:11
@jxtngx jxtngx marked this pull request as ready for review July 28, 2022 01:35
jxtngx
jxtngx commented Jul 28, 2022
View reviewed changes
awaelchli
awaelchli reviewed Jul 28, 2022
View reviewed changes
@carmocca carmocca modified the milestones: pl:1.6.x, pl:1.8 Jul 28, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 2, 2022
awaelchli
awaelchli reviewed Aug 2, 2022
View reviewed changes
awaelchli
awaelchli approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

rohitgr7
rohitgr7 approved these changes Aug 3, 2022
View reviewed changes
@jxtngx @rohitgr7
commit suggestion
d9bdbf1 
commit suggestion #13692 (comment)

Co-authored-by: Rohit Gupta <[email protected]>
@awaelchli awaelchli enabled auto-merge (squash) August 3, 2022 19:02
@awaelchli awaelchli merged commit 7240bdb into Lightning-AI:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@otaj otaj otaj approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees
No one assigned
Labels
code quality logger: neptune pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
5 participants
@jxtngx @otaj @awaelchli @rohitgr7 @carmocca