Skip to content

Add debug framework #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

wangtao0101
Copy link

Add debug framework #241 and currently support javascript and python3.

add debug framework for javascript and python

almost debug version for javascript without judge

transform some param type

add debug framework for javascript and python

add debug-default command to use default  testcase

catch error in entry

fix a  bug whe  paramtype is  string

add debug framework for javascript and python

add debug framework for javascript and python

a small protocal between extension and debug session

use leetcode  to judge  result

remove unused change

bug: fix parse param bug.

bug: eacape  string when  submit to leetcode

support TreeNode type

support  debug for python3

demo for support python

special code for Node parameter

parse Node parameter

python debug use new framework

feat: support python and update problemTypes

fix: fix bug of get problem meta of .com

fix: fix rebase issue

fix: use new testcase

fix: remove 430 558

feat: support some python problem

feat: support some python problem

feat: submit for python after debug

add docs and demo
@lgtm-com
Copy link

lgtm-com bot commented Mar 2, 2020

This pull request introduces 3 alerts when merging 1663f9e into bedd693 - view on LGTM.com

new alerts:

  • 2 for Incomplete string escaping or encoding
  • 1 for Unused variable, import, function or class

@jdneo
Copy link
Member

jdneo commented Mar 12, 2020

@wangtao0101 Thank you for the contribution. So far, I noticed some problems in this PR:

  1. This is a too big PR which is almost impossible to review
  2. There are some file changes which I cannot know why, like some files with number, e.g. src/debug/entry/javascript/problems/116.js

Just as I have said, so far I don't want to embed the debug features into this extension, for the following reasons:

  • Impossible to provide a general debug framework for all languages
  • Too much uncertainties, any of the dependent language extension changes its API, we breaks.

So, my suggestion is that, you can build and publish your own extension for a specific language's debug scenario, if you need any help, I'm willing to help you.

@wangtao0101
Copy link
Author

@jdneo Thank you for your suggestion. I will publish my own extension.

@wangtao0101 wangtao0101 deleted the debug branch March 14, 2020 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants