Skip to content

fix: use pinyin instead of Chinese in file name for leetcode-cn problem #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

poppinlp
Copy link
Contributor

This PR is for #166

  • Add a dependency pinyin to generate slug for Chinese.
  • Add a function to generate slug by problem name and endpoint.

@jdneo
Copy link
Member

jdneo commented Mar 1, 2019

@poppinlp Thank you for providing the fix.

Hmm, what I'm actually thinking is that can we make sure that using Pinyin is better than Chinese for our users. At least for me, I have no answers to this question now.

So my suggestion is we can just leave this fix for a while, wait for our users' feedback and decide where we should go, what do you think?

@poppinlp
Copy link
Contributor Author

poppinlp commented Mar 1, 2019

For me, I think it's a little bit strange to use Chinese in a file name.
But I agree with you that we could wait for more feedback. :)

@magic-akari
Copy link
Contributor

Can we fetch the meta information from leetcode and use it in leetcode-cn?

@jdneo
Copy link
Member

jdneo commented Sep 30, 2019

Can we fetch the meta information from leetcode and use it in leetcode-cn?

Do you mean make the problem from leetcode-cn has the same name as those from leetcode, instead of using Chinese name?

@magic-akari
Copy link
Contributor

Can we fetch the meta information from leetcode and use it in leetcode-cn?

Do you mean make the problem from leetcode-cn has the same name as those from leetcode, instead of using Chinese name?

Yes, that is what I mean.

@jdneo
Copy link
Member

jdneo commented Sep 30, 2019

Cool, That seems a better solution. Do you want to have a look into this?

@poppinlp
Copy link
Contributor Author

Seems this PR is outdated with lots of conflicts. We may create another one for that solution.

@poppinlp poppinlp closed this Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants