Skip to content

Commit df68b0e

Browse files
committed
Submission provider fix
1 parent 82ec804 commit df68b0e

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

src/webview/LeetCodeWebview.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export abstract class LeetCodeWebview implements Disposable {
3030
if (!this.panel) {
3131
const option: ILeetCodeWebviewOption = this.getWebviewOption();
3232

33-
this.panel = window.createWebviewPanel(option.viewType, option.title, ViewColumn.One, {
33+
this.panel = window.createWebviewPanel(option.viewType, option.title, option.viewColumn || ViewColumn.One, {
3434
enableScripts: true,
3535
enableCommandUris: true,
3636
enableFindWidget: true,
@@ -59,5 +59,6 @@ export abstract class LeetCodeWebview implements Disposable {
5959
export interface ILeetCodeWebviewOption {
6060
viewType: string;
6161
title: string;
62+
viewColumn?: ViewColumn;
6263
onDidReceiveMessage?: (message: any) => Promise<void>;
6364
}

src/webview/leetCodeSubmissionProvider.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,11 @@ class LeetCodeSubmissionProvider extends LeetCodeWebview {
1616
}
1717
}
1818

19-
public dispose(): void {
20-
if (this.panel) {
21-
this.panel.dispose();
22-
}
23-
}
24-
2519
protected getWebviewOption(): ILeetCodeWebviewOption {
2620
return {
2721
viewType: "leetcode.submission",
2822
title: "Submission",
23+
viewColumn: ViewColumn.Two,
2924
};
3025
}
3126

0 commit comments

Comments
 (0)