Skip to content

Commit 617f047

Browse files
Address Copilot reviews - Use the same approach TestServerBuilder used.
- Use the same approach TestServerBuilder used: register a simple mock ISitecoreLayoutClient singleton instead of constructing a sampleRequest/sampleResponse.- ExperienceEditorCustomRoutingFixture.cs - wire layout service to mock HttpClient in RenderingEngine benchmarks
2 parents 7750d47 + 16b6bbc commit 617f047

File tree

2 files changed

+8
-23
lines changed

2 files changed

+8
-23
lines changed

tests/Sitecore.AspNetCore.SDK.RenderingEngine.Benchmarks/RenderingEngineBenchmarks.cs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
using Microsoft.Extensions.DependencyInjection;
88
using Sitecore.AspNetCore.SDK.AutoFixture.Mocks;
99
using Sitecore.AspNetCore.SDK.LayoutService.Client.Extensions;
10+
using Sitecore.AspNetCore.SDK.LayoutService.Client.Interfaces;
1011
using Sitecore.AspNetCore.SDK.RenderingEngine.Extensions;
1112
using Sitecore.AspNetCore.SDK.TestData;
1213

@@ -32,8 +33,12 @@ public void Setup()
3233
builder.ConfigureServices(services =>
3334
{
3435
services.AddRouting();
35-
services.AddSitecoreLayoutService();
36-
services.AddHttpClient("mock").ConfigurePrimaryHttpMessageHandler(() => _mockClientHandler!);
36+
37+
ISitecoreLayoutClientBuilder layoutBuilder = services.AddSitecoreLayoutService();
38+
layoutBuilder
39+
.AddHttpHandler("mock", _ => new HttpClient(_mockClientHandler!) { BaseAddress = new Uri("http://layout.service") })
40+
.AsDefaultHandler();
41+
3742
services.AddSitecoreRenderingEngine(options =>
3843
{
3944
options.AddDefaultComponentRenderer();

tests/Sitecore.AspNetCore.SDK.RenderingEngine.Integration.Tests/Fixtures/ExperienceEditor/ExperienceEditorCustomRoutingFixture.cs

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -64,27 +64,7 @@ private WebApplicationFactory<TestWebApplicationProgram> BuildExperienceEditorCu
6464
{
6565
builder.ConfigureTestServices(services =>
6666
{
67-
ISitecoreLayoutClient layoutClientSub = Substitute.For<ISitecoreLayoutClient>();
68-
SitecoreLayoutRequest sampleRequest = [];
69-
SitecoreLayoutResponse sampleResponse = new(sampleRequest)
70-
{
71-
Content = new SitecoreLayoutResponseContent
72-
{
73-
Sitecore = new SitecoreData
74-
{
75-
Route = new Route
76-
{
77-
DatabaseName = "master"
78-
}
79-
},
80-
ContextRawData = string.Empty
81-
}
82-
};
83-
84-
layoutClientSub.Request(Arg.Any<SitecoreLayoutRequest>())
85-
.Returns(Task.FromResult(sampleResponse));
86-
87-
services.AddSingleton(layoutClientSub);
67+
services.AddSingleton(Substitute.For<ISitecoreLayoutClient>());
8868
services.AddRouting();
8969
services.AddSitecoreLayoutService();
9070
services.AddControllersWithViews();

0 commit comments

Comments
 (0)