Remove deprecated APIs usage and enable warning-as-errors for build scripts (#2925)

* Fix deprecated URL constructor usage in build scripts.

* Enable warnings-as-errors for build scripts

This should force to update build scripts on any new deprecation introduced in the used plugins.

* Fix deprecation waring in teamcity-conventions.gradle.kts

* Suppress deprecation in native-targets-conventions.gradle.kts

* Use proper OptIn annotation in source-sets-conventions.gradle.kts

* Fix deprecation warnings in Java9Modularity.kt

* Suppress deprecation introduced in Kotlin 2.1.20 release.

Should be migrated once this project will start using Kotlin 2.1.20 by default.

* Enable warnings-as-errors for build logic compilation

This should force to update scripts on new deprecation introduced in the plugins.

* Enable warnings-as-errors for integration-tests project build scripts

* Remove deprecated 'kotlin.js.compiler' property

Only IR compiler available now.

Author: Tapchicoma

bom/build.gradle.kts

@@ -37,8 +37,11 @@ publishing {
         forEach { pub ->
             pub as DefaultMavenPublication
             pub.unsetModuleDescriptorGenerator()
-            tasks.matching { it.name == "generateMetadataFileFor${pub.name.capitalize()}Publication" }.all {
-                onlyIf { false }
+
+            tasks.configureEach {
+                if (name == "generateMetadataFileFor${pub.name.capitalizeCompat()}Publication") {
+                    onlyIf { false }
+                }
             }
         }
     }

build.gradle.kts

@@ -4,6 +4,7 @@
 
 import kotlinx.validation.*
 import org.jetbrains.dokka.gradle.*
+import org.jetbrains.kotlin.gradle.plugin.getKotlinPluginVersion
 
 plugins {
     base
@@ -157,10 +158,8 @@ tasks.withType<org.jetbrains.kotlin.gradle.targets.js.npm.tasks.KotlinNpmInstall
     args.add("--ignore-engines")
 }
 
-// == compiler version setup ==
-gradle.taskGraph.whenReady {
-    println("Using Kotlin compiler version: ${org.jetbrains.kotlin.config.KotlinCompilerVersion.VERSION}")
-}
+// == KGP version setup ==
+logger.warn("Project is using Kotlin Gradle plugin version: ${project.getKotlinPluginVersion()}")
 
 // == projects lists and flags ==
 // getters are required because of variable lazy initialization in Gradle

buildSrc/build.gradle.kts

@@ -37,6 +37,12 @@ repositories {
     mavenLocal()
 }
 
+kotlin {
+    compilerOptions {
+        allWarningsAsErrors = true
+    }
+}
+
 dependencies {
     implementation(libs.gradlePlugin.kotlin)
     implementation(libs.gradlePlugin.kover)

buildSrc/gradle.properties

@@ -0,0 +1 @@
+org.gradle.kotlin.dsl.allWarningsAsErrors=true

buildSrc/src/main/kotlin/Java9Modularity.kt

@@ -27,6 +27,13 @@ import kotlin.reflect.*
 import kotlin.reflect.full.*
 
 object Java9Modularity {
+    private val KotlinProjectExtension.targets: Iterable<KotlinTarget>
+        get() = when (this) {
+            is KotlinSingleTargetExtension<*> -> listOf(this.target)
+            is KotlinMultiplatformExtension -> targets
+            else -> error("Unexpected 'kotlin' extension $this")
+        }
+
 
     @JvmStatic
     @JvmOverloads
@@ -49,16 +56,19 @@ object Java9Modularity {
             }
 
             target.compilations.forEach { compilation ->
-                val compileKotlinTask = compilation.compileKotlinTask as KotlinCompile
+                @Suppress("UNCHECKED_CAST")
+                val compileKotlinTask = compilation.compileTaskProvider as TaskProvider<KotlinCompile>
                 val defaultSourceSet = compilation.defaultSourceSet
 
                 // derive the names of the source set and compile module task
                 val sourceSetName = defaultSourceSet.name + "Module"
 
                 kotlin.sourceSets.create(sourceSetName) {
                     val sourceFile = this.kotlin.find { it.name == "module-info.java" }
-                    val targetDirectory = compileKotlinTask.destinationDirectory.map {
-                        it.dir("../${it.asFile.name}Module")
+                    val targetDirectory = compileKotlinTask.flatMap { task ->
+                        task.destinationDirectory.map {
+                            it.dir("../${it.asFile.name}Module")
+                        }
                     }
 
                     // only configure the compilation if necessary
@@ -109,37 +119,38 @@ object Java9Modularity {
      * but it currently won't compile to a module-info.class file.
      */
     private fun Project.registerVerifyModuleTask(
-        compileTask: KotlinCompile,
+        compileTask: TaskProvider<KotlinCompile>,
         sourceFile: File
     ): TaskProvider<out KotlinJvmCompile> {
         apply<KotlinApiPlugin>()
+        @Suppress("DEPRECATION")
         val verifyModuleTaskName = "verify${compileTask.name.removePrefix("compile").capitalize()}Module"
         // work-around for https://youtrack.jetbrains.com/issue/KT-60542
         val kotlinApiPlugin = plugins.getPlugin(KotlinApiPlugin::class)
         val verifyModuleTask = kotlinApiPlugin.registerKotlinJvmCompileTask(
             verifyModuleTaskName,
-            compileTask.compilerOptions.moduleName.get()
+            compilerOptions = compileTask.get().compilerOptions,
+            explicitApiMode = provider { ExplicitApiMode.Disabled }
         )
         verifyModuleTask {
             group = VERIFICATION_GROUP
             description = "Verify Kotlin sources for JPMS problems"
-            libraries.from(compileTask.libraries)
-            source(compileTask.sources)
-            source(compileTask.javaSources)
+            libraries.from(compileTask.map { it.libraries })
+            source(compileTask.map { it.sources })
+            source(compileTask.map { it.javaSources })
             // part of work-around for https://youtrack.jetbrains.com/issue/KT-60541
-            @Suppress("INVISIBLE_MEMBER")
-            source(compileTask.scriptSources)
+            source(compileTask.map {
+                @Suppress("INVISIBLE_MEMBER")
+                it.scriptSources
+            })
             source(sourceFile)
             destinationDirectory.set(temporaryDir)
-            multiPlatformEnabled.set(compileTask.multiPlatformEnabled)
+            multiPlatformEnabled.set(compileTask.get().multiPlatformEnabled)
             compilerOptions {
                 jvmTarget.set(JvmTarget.JVM_9)
-                // To support LV override when set in aggregate builds
-                languageVersion.set(compileTask.compilerOptions.languageVersion)
                 freeCompilerArgs.addAll(
                     listOf("-Xjdk-release=9",  "-Xsuppress-version-warnings", "-Xexpect-actual-classes")
                 )
-                optIn.addAll(compileTask.kotlinOptions.options.optIn)
             }
             // work-around for https://youtrack.jetbrains.com/issue/KT-60583
             inputs.files(
@@ -160,18 +171,21 @@ object Java9Modularity {
                     .declaredMemberProperties
                     .find { it.name == "ownModuleName" }
                     ?.get(this) as? Property<String>
-                ownModuleNameProp?.set(compileTask.kotlinOptions.moduleName)
+                ownModuleNameProp?.set(compileTask.flatMap { it.compilerOptions.moduleName})
             }
 
             val taskKotlinLanguageVersion = compilerOptions.languageVersion.orElse(KotlinVersion.DEFAULT)
             @OptIn(InternalKotlinGradlePluginApi::class)
             if (taskKotlinLanguageVersion.get() < KotlinVersion.KOTLIN_2_0) {
                 // part of work-around for https://youtrack.jetbrains.com/issue/KT-60541
                 @Suppress("INVISIBLE_MEMBER")
-                commonSourceSet.from(compileTask.commonSourceSet)
+                commonSourceSet.from(compileTask.map {
+                    @Suppress("INVISIBLE_MEMBER")
+                    it.commonSourceSet
+                })
             } else {
-                multiplatformStructure.refinesEdges.set(compileTask.multiplatformStructure.refinesEdges)
-                multiplatformStructure.fragments.set(compileTask.multiplatformStructure.fragments)
+                multiplatformStructure.refinesEdges.set(compileTask.flatMap { it.multiplatformStructure.refinesEdges })
+                multiplatformStructure.fragments.set(compileTask.flatMap { it.multiplatformStructure.fragments })
             }
             // part of work-around for https://youtrack.jetbrains.com/issue/KT-60541
             // and work-around for https://youtrack.jetbrains.com/issue/KT-60582
@@ -181,7 +195,7 @@ object Java9Modularity {
     }
 
     private fun Project.registerCompileModuleTask(
-        compileTask: KotlinCompile,
+        compileTask: TaskProvider<KotlinCompile>,
         sourceFile: File,
         targetDirectory: Provider<out Directory>
     ) = tasks.register("${compileTask.name}Module", JavaCompile::class) {
@@ -201,10 +215,12 @@ object Java9Modularity {
 
         options.compilerArgumentProviders.add(object : CommandLineArgumentProvider {
             @get:CompileClasspath
-            val compileClasspath = compileTask.libraries
+            val compileClasspath = objects.fileCollection().from(
+                compileTask.map { it.libraries }
+            )
 
             @get:CompileClasspath
-            val compiledClasses = compileTask.destinationDirectory
+            val compiledClasses = compileTask.flatMap { it.destinationDirectory }
 
             @get:Input
             val moduleName = sourceFile

buildSrc/src/main/kotlin/dokka-conventions.gradle.kts

@@ -3,7 +3,7 @@
  */
 
 import org.jetbrains.dokka.gradle.*
-import java.net.URL
+import java.net.URI
 
 /*
  * Copyright 2017-2024 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license.
@@ -71,7 +71,7 @@ tasks.withType<DokkaTaskPartial>().named("dokkaHtmlPartial") {
             sourceLink {
                 localDirectory.set(rootDir)
 
-                remoteUrl.set(URL("https://github.com/Kotlin/kotlinx.serialization/tree/master"))
+                remoteUrl.set(URI("https://github.com/Kotlin/kotlinx.serialization/tree/master").toURL())
                 remoteLineSuffix.set("#L")
             }
         }

buildSrc/src/main/kotlin/native-targets-conventions.gradle.kts

@@ -45,6 +45,7 @@ kotlin {
         watchosDeviceArm64()
 
         // Deprecated, but not removed
+        @Suppress("DEPRECATION")
         linuxArm32Hfp()
     }