Skip to content

Add enum support for ApiV1Kt.generateEncoder #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 14, 2021

Conversation

nonpool
Copy link
Contributor

@nonpool nonpool commented Jul 14, 2021

[#98]

@asm0dey
Copy link
Contributor

asm0dey commented Jul 14, 2021

Thank you very much for your contribution! Could you please add support to 2.x Spark too?

@nonpool
Copy link
Contributor Author

nonpool commented Jul 14, 2021

Of course. I want to use this library for our project, Could you release a new release version as soon as possible?

@asm0dey
Copy link
Contributor

asm0dey commented Jul 14, 2021

@nonpool I expect to release 1.0.2 on June, 19. But if anything I can build and sign binaries for you earlier than that.

@asm0dey asm0dey merged commit a888ea4 into Kotlin:main Jul 14, 2021
@nonpool
Copy link
Contributor Author

nonpool commented Jul 15, 2021

OK,July 19 is the date to wait. Before that, we should fix the issue that the maven artifactId or documentation was incorrectly. I will fix this in other PR

@Jolanrensen
Copy link
Collaborator

@asm0dey Maybe you should also mention this in the release notes https://github.com/JetBrains/kotlin-spark-api/releases/tag/1.0.2 :) Might be important to know for some people.

@asm0dey
Copy link
Contributor

asm0dey commented Jul 20, 2021

Absolutely, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants