Skip to content

Add examples for rename #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Add examples for rename #952

merged 2 commits into from
Nov 20, 2024

Conversation

koperagen
Copy link
Collaborator

No description provided.

@koperagen koperagen self-assigned this Nov 15, 2024
@koperagen koperagen added the documentation Improvements or additions to documentation (not KDocs) label Nov 15, 2024
@koperagen koperagen added this to the 0.15.0 milestone Nov 15, 2024
<tab title="Properties">

```kotlin

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it ok to have here empty sections?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, looks like korro skipped these @koperagen

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad! Fixed it, thank you

fun renameExpression_accessors() {
// SampleStart
val age by column<Int>()
df.rename { age }.into {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these renameExpressions displayed below in tabs?

Copy link
Collaborator

@zaleslaw zaleslaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please answer my questions regarding documentation?

@koperagen koperagen force-pushed the documentation-updates branch from 945d08a to 8d8bd44 Compare November 20, 2024 12:29
@koperagen koperagen force-pushed the documentation-updates branch from 8d8bd44 to ead4f86 Compare November 20, 2024 12:34
@koperagen koperagen merged commit 111c0ff into master Nov 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation (not KDocs)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants