Move Jupyter integration from :core to a new module #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
changed the title
koperagen
force-pushed
the
jupyter-integration-module
branch
from
27261fd to
b7dd172
Compare
zaleslaw
approved these changes
Jul 9, 2024
koperagen
force-pushed
the
jupyter-integration-module
branch
from
b7dd172 to
52306e0
Compare
|
Generated sources will be updated after merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #241
fixes #700
The goal was to have this handy function:
ktor-client requires Java 11 compatibility, so it has to live in a different module if we want to keep 8.
So here's the refactoring that thanks to friend module wasn't that hard. Plus the integration with ktor-client itself.
TODO: After this PR is merged, we'd need to add "org.jetbrains.kotlinx:dataframe-jupyter.*" here https://github.com/Kotlin/kotlin-jupyter-libraries/blob/master/dataframe.json for future versions
I didn't move the whole jupyter package btw. Only parts that depend on jupyter-api.