Skip to content

Commit 851b1a6

Browse files
committed
marked aggregateBy for removal
1 parent bec19d9 commit 851b1a6

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/aggregation/aggregators/Aggregator.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ internal interface Aggregator<in Value, out Return> {
5353

5454
/**
5555
* Special case of [aggregate] with [Iterable] that calculates the common type of the values at runtime.
56-
* This is a heavy operation and should be avoided when possible.
56+
* Without [valueTypes], this is a heavy operation and should be avoided when possible.
5757
*
5858
* @param values The values to be aggregated.
5959
* @param valueTypes The types of the values.

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/aggregation/aggregators/TwoStepNumbersAggregator.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ internal class TwoStepNumbersAggregator<out Return : Number>(
114114
/**
115115
* Special case of [aggregate] with [Iterable] that calculates the [unified number type][UnifyingNumbers]
116116
* of the values at runtime and converts all numbers to this type before aggregating.
117-
* This is a heavy operation and should be avoided when possible.
117+
* Without [valueTypes], this is a heavy operation and should be avoided when possible.
118118
*
119119
* @param values The numbers to be aggregated.
120120
* @param valueTypes The types of the numbers.

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/aggregation/modes/aggregateBy.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,14 @@ package org.jetbrains.kotlinx.dataframe.impl.aggregation.modes
33
import org.jetbrains.kotlinx.dataframe.DataFrame
44
import org.jetbrains.kotlinx.dataframe.DataFrameExpression
55
import org.jetbrains.kotlinx.dataframe.DataRow
6+
import org.jetbrains.kotlinx.dataframe.annotations.CandidateForRemoval
67
import org.jetbrains.kotlinx.dataframe.api.GroupBy
78
import org.jetbrains.kotlinx.dataframe.api.Grouped
89
import org.jetbrains.kotlinx.dataframe.api.cast
910
import org.jetbrains.kotlinx.dataframe.impl.aggregation.aggregateInternal
1011
import org.jetbrains.kotlinx.dataframe.impl.namedValues
1112

13+
@CandidateForRemoval
1214
internal fun <T> Grouped<T>.aggregateBy(body: DataFrameExpression<T, DataRow<T>?>): DataFrame<T> {
1315
require(this is GroupBy<*, T>)
1416
val keyColumns = keys.columnNames().toSet()

0 commit comments

Comments
 (0)