Merge pull request #159 from GrahamCampbell/testing

Testing Improvements

Author: cursedcoder

.travis.yml

@@ -8,12 +8,9 @@ php:
   - 5.6
   - hhvm
 
-matrix:
-  allow_failures:
-    - php: hhvm
-
 before_script:
-  - composer install --dev --prefer-source
+  - travis_retry composer self-update
+  - travis_retry composer install --no-interaction --prefer-source --dev
 
 script:
-  - phpunit --coverage-text
+  - vendor/bin/phpunit --verbose --coverage-text

lib/Github/Api/Repository/Assets.php

@@ -67,7 +67,7 @@ public function show($username, $repository, $id)
     public function create($username, $repository, $id, $name, $contentType, $content)
     {
         if (!defined('OPENSSL_TLSEXT_SERVER_NAME') || !OPENSSL_TLSEXT_SERVER_NAME) {
-            throw new ErrorException('Asset upload support requires Server Name Indication. This is not supported se your PHP version. See http://php.net/manual/en/openssl.constsni.php.');
+            throw new ErrorException('Asset upload support requires Server Name Indication. This is not supported by your PHP version. See http://php.net/manual/en/openssl.constsni.php.');
         }
 
         // Asset creation requires a separate endpoint, uploads.github.com.

test/Github/Tests/Api/Repository/AssetsTest.php

@@ -46,6 +46,12 @@ public function shouldGetSingleReleaseAsset()
      */
     public function shouldCreateReleaseAsset()
     {
+        if (!defined('OPENSSL_TLSEXT_SERVER_NAME') || !OPENSSL_TLSEXT_SERVER_NAME) {
+            return $this->markTestSkipped(
+                'Asset upload support requires Server Name Indication. This is not supported be your PHP version.'
+            );
+        }
+
         $name = 'asset.gzip';
         $body = 'assetCreatedData';
         $contentType = 'application/gzip';