Merge pull request #231 from keradus/lowercase_constants

pilot · pilot · commit 3afd34d7ab31 · 2015-02-13T01:06:19.000+02:00
CS: The PHP constants true, false, and null MUST be in lower case.
diff --git a/lib/Github/Api/Repository/Commits.php b/lib/Github/Api/Repository/Commits.php
@@ -15,10 +15,10 @@ public function all($username, $repository, array $params)
         return $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/commits', $params);
     }
 
-    public function compare($username, $repository, $base, $head, $mediaType = NULL)
+    public function compare($username, $repository, $base, $head, $mediaType = null)
     {
         $headers = array();
-        if (NULL !== $mediaType) {
+        if (null !== $mediaType) {
             $headers['Accept'] = $mediaType;
         }
         return $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/compare/'.rawurlencode($base).'...'.rawurlencode($head), array(), $headers);

Original file line number	Diff line number	Diff line change
`@@ -15,10 +15,10 @@ public function all($username, $repository, array $params)`
`15`	`15`	`return $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/commits', $params);`
`16`	`16`	`}`
`17`	`17`
`18`		`- public function compare($username, $repository, $base, $head, $mediaType = NULL)`
	`18`	`+ public function compare($username, $repository, $base, $head, $mediaType = null)`
`19`	`19`	`{`
`20`	`20`	`$headers = array();`
`21`		`- if (NULL !== $mediaType) {`
	`21`	`+ if (null !== $mediaType) {`
`22`	`22`	`$headers['Accept'] = $mediaType;`
`23`	`23`	`}`
`24`	`24`	`return $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/compare/'.rawurlencode($base).'...'.rawurlencode($head), array(), $headers);`