Migrate build and setup from setup.py to pyproject.toml #52
Conversation
axelfauvel
force-pushed
the
move-to-pyproject.toml
branch
from
e6bf2e0 to
e23e955
Compare
| @@ -1 +1,3 @@ | |||
| __version__ = '0.0.5' | |||
| import pkg_resources | |||
There was a problem hiding this comment.
Should we use the newer importlib.metadata instead?
| @@ -0,0 +1,71 @@ | |||
| [build-system] | |||
| requires = ["setuptools", "setuptools-scm"] | |||
There was a problem hiding this comment.
I wouldn't choose setuptools as the build backend as it has to support many legacy workflows that prevent innovations in other tools. I would propose hatchling.build as the official tutorial does https://packaging.python.org/en/latest/tutorials/packaging-projects/#creating-pyproject-toml (although implicitly as listing it as the first choice)
|
|
||
| [project] | ||
| name = "python-multipart" | ||
| version = "0.0.5" |
| 'Topic :: Software Development :: Libraries :: Python Modules' | ||
| ] | ||
| dependencies = [ | ||
| "atomicwrites==1.2.1", |
There was a problem hiding this comment.
Dependencies should not be hard pinned here as it forces ALL users of this lib to use SPECIFICALLY this version. More relaxed requirements as atomicwrites>=1.0.0 are prefered. The minimum version that works, the better, that allows users more freedom to pin in their apps without a dependency (that's even transitive in the case of fastapi users) forcing you to certain version that might have a security vuln for example
| "Homepage" = 'https://github.com/andrew-d/python-multipart' | ||
|
|
||
| [project.optional-dependencies] | ||
| dev = [ |
There was a problem hiding this comment.
If we were to pin, here would be better as it will only be done if we're setting up a dev enviornment, not a library usage environment
|
Thank you for your work Axel! Left my review, let me know if i wasn't clear in any of my suggestions |
|
Thanks for the review Nahuel, I'll work on it tomorrow |
|
Hi, let me know if you need some help. If you don't have time i can update the or too with @Kludex suggestion |
|
Hi @Ambro17 : It's been pretty crazy at work lately. If you want to implement changes, please feel free to do so |
|
@Ambro17 do you take care of this or should I? |
|
Ah, this was already done. |
As discussed in #37
Here is the first part towards automating the release process. You can now run the following code to build the package :
This will generate both
.whland.tar.gzfiles, last step will be to publish them to pypi using twine.What is in this PR ?
requirements.txt&setup.pytopyproject.toml__version__from package topyproject.toml