Update pre-commit hooks

- Update pre-commit hooks coming from `pre-commit autoupdate`
- Fix new pylint problems

Author: folmos-at-orange

.pre-commit-config.yaml

@@ -1,12 +1,12 @@
 ---
 repos:
   - repo: https://github.com/psf/black-pre-commit-mirror
-    rev: 24.3.0
+    rev: 24.4.2
     hooks:
       - id: black
         language_version: python3
   - repo: https://github.com/pycqa/pylint
-    rev: v3.1.0
+    rev: v3.2.5
     hooks:
       - id: pylint
         language_version: python3
@@ -22,7 +22,7 @@ repos:
       - id: yamlfix
         exclude: packaging/conda/meta.yaml
   - repo: https://github.com/python-jsonschema/check-jsonschema
-    rev: 0.28.1
+    rev: 0.29.0
     hooks:
       - id: check-github-workflows
         args: [--verbose]

khiops/core/api.py

@@ -293,7 +293,7 @@ def _preprocess_task_arguments(task_args):
         ):
             warnings.warn(
                 deprecation_message(
-                    f"'discretization_method' on supervised learning",
+                    "'discretization_method' on supervised learning",
                     "11.0.0",
                     quote=False,
                 )

khiops/core/internals/runner.py

@@ -1743,6 +1743,9 @@ def _get_tool_info_khiops9(runner, tool_name):
 
     # If tool executed successfully:
     if return_code == 0:
+        # Since pylint 3.2.5 an used before assignment error appears with no reason
+        # This code is going to be eliminated in Khiops 11 so no need to fix it
+        # pylint: disable=used-before-assignment,possibly-used-before-assignment
         # Parse the contents of the log file
         tmp_log_file_contents = io.BytesIO(fs.read(tmp_log_file_path))
         with io.TextIOWrapper(tmp_log_file_contents, encoding="ascii") as tmp_log_file:

khiops/core/internals/task.py

@@ -668,8 +668,9 @@ def latest_intro_version(self):
         """`.KhiopsVersion` : Latest introduction version overall tasks"""
         latest_intro_version = KhiopsVersion("1.0")
         for task_family in self.task_families:
-            if task_family.latest_intro_version > latest_intro_version:
-                latest_intro_version = task_family.latest_intro_version
+            latest_intro_version = max(
+                task_family.latest_intro_version, latest_intro_version
+            )
         return latest_intro_version
 
     @property

tests/test_dataset_class.py

@@ -265,7 +265,8 @@ def create_fixture_dataset_spec(self, output_dir, data_type, multitable, schema)
                     "tables": {"Reviews": (features, "User_ID")},
                 }
                 label = reference_table["class"]
-            elif data_type == "file":
+            else:
+                assert data_type == "file"
                 reference_table_path = os.path.join(output_dir, "Reviews.csv")
                 self.create_monotable_data_file(reference_table_path)
                 dataset_spec = {
@@ -274,7 +275,6 @@ def create_fixture_dataset_spec(self, output_dir, data_type, multitable, schema)
                     "format": ("\t", True),
                 }
                 label = "class"
-
         elif schema == "star":
             if data_type == "df":
                 (
@@ -292,7 +292,8 @@ def create_fixture_dataset_spec(self, output_dir, data_type, multitable, schema)
                     },
                 }
                 label = reference_main_table["class"]
-            elif data_type == "file":
+            else:
+                assert data_type == "file"
                 reference_main_table_path = os.path.join(output_dir, "id_class.csv")
                 reference_secondary_table_path = os.path.join(output_dir, "logs.csv")
                 self.create_multitable_star_data_files(
@@ -307,8 +308,8 @@ def create_fixture_dataset_spec(self, output_dir, data_type, multitable, schema)
                     "format": ("\t", True),
                 }
                 label = "class"
-
-        else:  # schema == "snowflake":
+        else:
+            assert schema == "snowflake"
             if data_type == "df":
                 (
                     reference_main_table,
@@ -344,7 +345,8 @@ def create_fixture_dataset_spec(self, output_dir, data_type, multitable, schema)
                     ],
                 }
                 label = reference_main_table["class"]
-            elif data_type == "file":
+            else:
+                assert data_type == "file"
                 reference_main_table_path = os.path.join(output_dir, "A.csv")
                 reference_secondary_table_path_1 = os.path.join(output_dir, "B.csv")
                 reference_secondary_table_path_2 = os.path.join(output_dir, "C.csv")
@@ -481,7 +483,7 @@ def test_dataset_is_correctly_built(self):
         self.assertEqual(dataset.main_table.name, "A")
         self.assertEqual(len(dataset.secondary_tables), 4)
         dataset_secondary_table_names = set(
-            [secondary_table.name for secondary_table in dataset.secondary_tables]
+            secondary_table.name for secondary_table in dataset.secondary_tables
         )
         self.assertEqual(dataset_secondary_table_names, {"B", "C", "D", "E"})
         self.assertEqual(len(dataset.relations), 4)

tests/test_helper.py

@@ -215,11 +215,9 @@ def function_mock(_mocked, _instance, args, kwargs):
                 log_file_path = self.fixture["extra_file_paths"]["log_file_path"]
                 shutil.copyfile(log_file_path, kwargs["log_file_path"])
 
-            # No output: return None
-            if self.return_value_number == 0:
-                mocked_return_value = None
             # Build mocked output
-            elif self.return_value_number >= 1:
+            mocked_return_value = None
+            if self.return_value_number >= 1:
                 # Build the return values list
                 mocked_return_values = []
                 for return_value, is_mocked_file in self.fixture["return_values"]: