Skip to content

Commit c175433

Browse files
author
Mikhail Koviazin
committed
test: drop skip_if_server_version_lt for obsolete versions
Signed-off-by: Mikhail Koviazin <[email protected]>
1 parent fdc01c5 commit c175433

16 files changed

+6
-554
lines changed

tests/test_asyncio/test_cluster.py

Lines changed: 0 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
assert_resp_response,
1414
is_resp2_connection,
1515
skip_if_server_version_gte,
16-
skip_if_server_version_lt,
1716
skip_unless_arch_bits,
1817
)
1918
from valkey._parsers import AsyncCommandsParser
@@ -1052,7 +1051,6 @@ async def test_cluster_myid(self, r: ValkeyCluster) -> None:
10521051
myid = await r.cluster_myid(node)
10531052
assert len(myid) == 40
10541053

1055-
@skip_if_server_version_lt("7.2.0")
10561054
async def test_cluster_myshardid(self, r: ValkeyCluster) -> None:
10571055
node = r.get_random_node()
10581056
myshardid = await r.cluster_myshardid(node)
@@ -1071,7 +1069,6 @@ async def test_cluster_addslots(self, r: ValkeyCluster) -> None:
10711069
mock_node_resp(node, "OK")
10721070
assert await r.cluster_addslots(node, 1, 2, 3) is True
10731071

1074-
@skip_if_server_version_lt("7.0.0")
10751072
async def test_cluster_addslotsrange(self, r: ValkeyCluster):
10761073
node = r.get_random_node()
10771074
mock_node_resp(node, "OK")
@@ -1103,7 +1100,6 @@ async def test_cluster_delslots(self) -> None:
11031100

11041101
await r.aclose()
11051102

1106-
@skip_if_server_version_lt("7.0.0")
11071103
async def test_cluster_delslotsrange(self):
11081104
r = await get_mocked_valkey_client(host=default_host, port=default_port)
11091105
mock_all_nodes_resp(r, "OK")
@@ -1280,7 +1276,6 @@ async def test_cluster_replicas(self, r: ValkeyCluster) -> None:
12801276
== "r4xfga22229cf3c652b6fca0d09ff69f3e0d4d"
12811277
)
12821278

1283-
@skip_if_server_version_lt("7.0.0")
12841279
async def test_cluster_links(self, r: ValkeyCluster):
12851280
node = r.get_random_node()
12861281
res = await r.cluster_links(node)
@@ -1411,16 +1406,13 @@ async def test_time(self, r: ValkeyCluster) -> None:
14111406
assert isinstance(t[0], int)
14121407
assert isinstance(t[1], int)
14131408

1414-
@skip_if_server_version_lt("4.0.0")
14151409
async def test_memory_usage(self, r: ValkeyCluster) -> None:
14161410
await r.set("foo", "bar")
14171411
assert isinstance(await r.memory_usage("foo"), int)
14181412

1419-
@skip_if_server_version_lt("4.0.0")
14201413
async def test_memory_malloc_stats(self, r: ValkeyCluster) -> None:
14211414
assert await r.memory_malloc_stats()
14221415

1423-
@skip_if_server_version_lt("4.0.0")
14241416
async def test_memory_stats(self, r: ValkeyCluster) -> None:
14251417
# put a key into the current db to make sure that "db.<current-db>"
14261418
# has data
@@ -1432,12 +1424,10 @@ async def test_memory_stats(self, r: ValkeyCluster) -> None:
14321424
if key.startswith("db."):
14331425
assert isinstance(value, dict)
14341426

1435-
@skip_if_server_version_lt("4.0.0")
14361427
async def test_memory_help(self, r: ValkeyCluster) -> None:
14371428
with pytest.raises(NotImplementedError):
14381429
await r.memory_help()
14391430

1440-
@skip_if_server_version_lt("4.0.0")
14411431
async def test_memory_doctor(self, r: ValkeyCluster) -> None:
14421432
with pytest.raises(NotImplementedError):
14431433
await r.memory_doctor()
@@ -1450,7 +1440,6 @@ async def test_cluster_echo(self, r: ValkeyCluster) -> None:
14501440
node = r.get_primaries()[0]
14511441
assert await r.echo("foo bar", target_nodes=node) == b"foo bar"
14521442

1453-
@skip_if_server_version_lt("1.0.0")
14541443
async def test_debug_segfault(self, r: ValkeyCluster) -> None:
14551444
with pytest.raises(NotImplementedError):
14561445
await r.debug_segfault()
@@ -1468,52 +1457,44 @@ async def test_config_resetstat(self, r: ValkeyCluster) -> None:
14681457
)
14691458
assert reset_commands_processed < prior_commands_processed
14701459

1471-
@skip_if_server_version_lt("6.2.0")
14721460
async def test_client_trackinginfo(self, r: ValkeyCluster) -> None:
14731461
node = r.get_primaries()[0]
14741462
res = await r.client_trackinginfo(target_nodes=node)
14751463
assert len(res) > 2
14761464
assert "prefixes" in res or b"prefixes" in res
14771465

1478-
@skip_if_server_version_lt("2.9.50")
14791466
async def test_client_pause(self, r: ValkeyCluster) -> None:
14801467
node = r.get_primaries()[0]
14811468
assert await r.client_pause(1, target_nodes=node)
14821469
assert await r.client_pause(timeout=1, target_nodes=node)
14831470
with pytest.raises(ValkeyError):
14841471
await r.client_pause(timeout="not an integer", target_nodes=node)
14851472

1486-
@skip_if_server_version_lt("6.2.0")
14871473
async def test_client_unpause(self, r: ValkeyCluster) -> None:
14881474
assert await r.client_unpause()
14891475

1490-
@skip_if_server_version_lt("5.0.0")
14911476
async def test_client_id(self, r: ValkeyCluster) -> None:
14921477
node = r.get_primaries()[0]
14931478
assert await r.client_id(target_nodes=node) > 0
14941479

1495-
@skip_if_server_version_lt("5.0.0")
14961480
async def test_client_unblock(self, r: ValkeyCluster) -> None:
14971481
node = r.get_primaries()[0]
14981482
myid = await r.client_id(target_nodes=node)
14991483
assert not await r.client_unblock(myid, target_nodes=node)
15001484
assert not await r.client_unblock(myid, error=True, target_nodes=node)
15011485
assert not await r.client_unblock(myid, error=False, target_nodes=node)
15021486

1503-
@skip_if_server_version_lt("6.0.0")
15041487
async def test_client_getredir(self, r: ValkeyCluster) -> None:
15051488
node = r.get_primaries()[0]
15061489
assert isinstance(await r.client_getredir(target_nodes=node), int)
15071490
assert await r.client_getredir(target_nodes=node) == -1
15081491

1509-
@skip_if_server_version_lt("6.2.0")
15101492
async def test_client_info(self, r: ValkeyCluster) -> None:
15111493
node = r.get_primaries()[0]
15121494
info = await r.client_info(target_nodes=node)
15131495
assert isinstance(info, dict)
15141496
assert "addr" in info
15151497

1516-
@skip_if_server_version_lt("2.6.9")
15171498
async def test_client_kill(
15181499
self, r: ValkeyCluster, create_valkey: Callable[..., ValkeyCluster]
15191500
) -> None:
@@ -1541,29 +1522,25 @@ async def test_client_kill(
15411522
assert clients[0].get("name") == "valkey-py-c1"
15421523
await r2.aclose()
15431524

1544-
@skip_if_server_version_lt("2.6.0")
15451525
async def test_cluster_bitop_not_empty_string(self, r: ValkeyCluster) -> None:
15461526
await r.set("{foo}a", "")
15471527
await r.bitop("not", "{foo}r", "{foo}a")
15481528
assert await r.get("{foo}r") is None
15491529

1550-
@skip_if_server_version_lt("2.6.0")
15511530
async def test_cluster_bitop_not(self, r: ValkeyCluster) -> None:
15521531
test_str = b"\xAA\x00\xFF\x55"
15531532
correct = ~0xAA00FF55 & 0xFFFFFFFF
15541533
await r.set("{foo}a", test_str)
15551534
await r.bitop("not", "{foo}r", "{foo}a")
15561535
assert int(binascii.hexlify(await r.get("{foo}r")), 16) == correct
15571536

1558-
@skip_if_server_version_lt("2.6.0")
15591537
async def test_cluster_bitop_not_in_place(self, r: ValkeyCluster) -> None:
15601538
test_str = b"\xAA\x00\xFF\x55"
15611539
correct = ~0xAA00FF55 & 0xFFFFFFFF
15621540
await r.set("{foo}a", test_str)
15631541
await r.bitop("not", "{foo}a", "{foo}a")
15641542
assert int(binascii.hexlify(await r.get("{foo}a")), 16) == correct
15651543

1566-
@skip_if_server_version_lt("2.6.0")
15671544
async def test_cluster_bitop_single_string(self, r: ValkeyCluster) -> None:
15681545
test_str = b"\x01\x02\xFF"
15691546
await r.set("{foo}a", test_str)
@@ -1574,7 +1551,6 @@ async def test_cluster_bitop_single_string(self, r: ValkeyCluster) -> None:
15741551
assert await r.get("{foo}res2") == test_str
15751552
assert await r.get("{foo}res3") == test_str
15761553

1577-
@skip_if_server_version_lt("2.6.0")
15781554
async def test_cluster_bitop_string_operands(self, r: ValkeyCluster) -> None:
15791555
await r.set("{foo}a", b"\x01\x02\xFF\xFF")
15801556
await r.set("{foo}b", b"\x01\x02\xFF")
@@ -1585,28 +1561,24 @@ async def test_cluster_bitop_string_operands(self, r: ValkeyCluster) -> None:
15851561
assert int(binascii.hexlify(await r.get("{foo}res2")), 16) == 0x0102FFFF
15861562
assert int(binascii.hexlify(await r.get("{foo}res3")), 16) == 0x000000FF
15871563

1588-
@skip_if_server_version_lt("6.2.0")
15891564
async def test_cluster_copy(self, r: ValkeyCluster) -> None:
15901565
assert await r.copy("{foo}a", "{foo}b") == 0
15911566
await r.set("{foo}a", "bar")
15921567
assert await r.copy("{foo}a", "{foo}b") == 1
15931568
assert await r.get("{foo}a") == b"bar"
15941569
assert await r.get("{foo}b") == b"bar"
15951570

1596-
@skip_if_server_version_lt("6.2.0")
15971571
async def test_cluster_copy_and_replace(self, r: ValkeyCluster) -> None:
15981572
await r.set("{foo}a", "foo1")
15991573
await r.set("{foo}b", "foo2")
16001574
assert await r.copy("{foo}a", "{foo}b") == 0
16011575
assert await r.copy("{foo}a", "{foo}b", replace=True) == 1
16021576

1603-
@skip_if_server_version_lt("6.2.0")
16041577
async def test_cluster_lmove(self, r: ValkeyCluster) -> None:
16051578
await r.rpush("{foo}a", "one", "two", "three", "four")
16061579
assert await r.lmove("{foo}a", "{foo}b")
16071580
assert await r.lmove("{foo}a", "{foo}b", "right", "left")
16081581

1609-
@skip_if_server_version_lt("6.2.0")
16101582
async def test_cluster_blmove(self, r: ValkeyCluster) -> None:
16111583
await r.rpush("{foo}a", "one", "two", "three", "four")
16121584
assert await r.blmove("{foo}a", "{foo}b", 5)
@@ -1767,15 +1739,13 @@ async def test_cluster_sunionstore(self, r: ValkeyCluster) -> None:
17671739
assert await r.sunionstore("{foo}c", "{foo}a", "{foo}b") == 3
17681740
assert await r.smembers("{foo}c") == {b"1", b"2", b"3"}
17691741

1770-
@skip_if_server_version_lt("6.2.0")
17711742
async def test_cluster_zdiff(self, r: ValkeyCluster) -> None:
17721743
await r.zadd("{foo}a", {"a1": 1, "a2": 2, "a3": 3})
17731744
await r.zadd("{foo}b", {"a1": 1, "a2": 2})
17741745
assert await r.zdiff(["{foo}a", "{foo}b"]) == [b"a3"]
17751746
response = await r.zdiff(["{foo}a", "{foo}b"], withscores=True)
17761747
assert_resp_response(r, response, [b"a3", b"3"], [[b"a3", 3.0]])
17771748

1778-
@skip_if_server_version_lt("6.2.0")
17791749
async def test_cluster_zdiffstore(self, r: ValkeyCluster) -> None:
17801750
await r.zadd("{foo}a", {"a1": 1, "a2": 2, "a3": 3})
17811751
await r.zadd("{foo}b", {"a1": 1, "a2": 2})
@@ -1784,7 +1754,6 @@ async def test_cluster_zdiffstore(self, r: ValkeyCluster) -> None:
17841754
response = await r.zrange("{foo}out", 0, -1, withscores=True)
17851755
assert_resp_response(r, response, [(b"a3", 3.0)], [[b"a3", 3.0]])
17861756

1787-
@skip_if_server_version_lt("6.2.0")
17881757
async def test_cluster_zinter(self, r: ValkeyCluster) -> None:
17891758
await r.zadd("{foo}a", {"a1": 1, "a2": 2, "a3": 1})
17901759
await r.zadd("{foo}b", {"a1": 2, "a2": 2, "a3": 2})
@@ -1880,7 +1849,6 @@ async def test_cluster_zinterstore_with_weight(self, r: ValkeyCluster) -> None:
18801849
[[b"a3", 20.0], [b"a1", 23.0]],
18811850
)
18821851

1883-
@skip_if_server_version_lt("4.9.0")
18841852
async def test_cluster_bzpopmax(self, r: ValkeyCluster) -> None:
18851853
await r.zadd("{foo}a", {"a1": 1, "a2": 2})
18861854
await r.zadd("{foo}b", {"b1": 10, "b2": 20})
@@ -1917,7 +1885,6 @@ async def test_cluster_bzpopmax(self, r: ValkeyCluster) -> None:
19171885
[b"{foo}c", b"c1", 100],
19181886
)
19191887

1920-
@skip_if_server_version_lt("4.9.0")
19211888
async def test_cluster_bzpopmin(self, r: ValkeyCluster) -> None:
19221889
await r.zadd("{foo}a", {"a1": 1, "a2": 2})
19231890
await r.zadd("{foo}b", {"b1": 10, "b2": 20})
@@ -1954,7 +1921,6 @@ async def test_cluster_bzpopmin(self, r: ValkeyCluster) -> None:
19541921
[b"{foo}c", b"c1", 100],
19551922
)
19561923

1957-
@skip_if_server_version_lt("6.2.0")
19581924
async def test_cluster_zrangestore(self, r: ValkeyCluster) -> None:
19591925
await r.zadd("{foo}a", {"a1": 1, "a2": 2, "a3": 3})
19601926
assert await r.zrangestore("{foo}b", "{foo}a", 0, 1)
@@ -1981,7 +1947,6 @@ async def test_cluster_zrangestore(self, r: ValkeyCluster) -> None:
19811947
)
19821948
assert await r.zrange("{foo}b", 0, -1) == [b"a2"]
19831949

1984-
@skip_if_server_version_lt("6.2.0")
19851950
async def test_cluster_zunion(self, r: ValkeyCluster) -> None:
19861951
await r.zadd("{foo}a", {"a1": 1, "a2": 1, "a3": 1})
19871952
await r.zadd("{foo}b", {"a1": 2, "a2": 2, "a3": 2})
@@ -2085,7 +2050,6 @@ async def test_cluster_zunionstore_with_weight(self, r: ValkeyCluster) -> None:
20852050
[[b"a2", 5.0], [b"a4", 12.0], [b"a3", 20.0], [b"a1", 23.0]],
20862051
)
20872052

2088-
@skip_if_server_version_lt("2.8.9")
20892053
async def test_cluster_pfcount(self, r: ValkeyCluster) -> None:
20902054
members = {b"1", b"2", b"3"}
20912055
await r.pfadd("{foo}a", *members)
@@ -2095,7 +2059,6 @@ async def test_cluster_pfcount(self, r: ValkeyCluster) -> None:
20952059
assert await r.pfcount("{foo}b") == len(members_b)
20962060
assert await r.pfcount("{foo}a", "{foo}b") == len(members_b.union(members))
20972061

2098-
@skip_if_server_version_lt("2.8.9")
20992062
async def test_cluster_pfmerge(self, r: ValkeyCluster) -> None:
21002063
mema = {b"1", b"2", b"3"}
21012064
memb = {b"2", b"3", b"4"}
@@ -2114,7 +2077,6 @@ async def test_cluster_sort_store(self, r: ValkeyCluster) -> None:
21142077
assert await r.lrange("{foo}sorted_values", 0, -1) == [b"1", b"2", b"3"]
21152078

21162079
# GEO COMMANDS
2117-
@skip_if_server_version_lt("6.2.0")
21182080
async def test_cluster_geosearchstore(self, r: ValkeyCluster) -> None:
21192081
values = (2.1909389952632, 41.433791470673, "place1") + (
21202082
2.1873744593677,
@@ -2133,7 +2095,6 @@ async def test_cluster_geosearchstore(self, r: ValkeyCluster) -> None:
21332095
assert await r.zrange("{foo}places_barcelona", 0, -1) == [b"place1"]
21342096

21352097
@skip_unless_arch_bits(64)
2136-
@skip_if_server_version_lt("6.2.0")
21372098
async def test_geosearchstore_dist(self, r: ValkeyCluster) -> None:
21382099
values = (2.1909389952632, 41.433791470673, "place1") + (
21392100
2.1873744593677,
@@ -2153,7 +2114,6 @@ async def test_geosearchstore_dist(self, r: ValkeyCluster) -> None:
21532114
# instead of save the geo score, the distance is saved.
21542115
assert await r.zscore("{foo}places_barcelona", "place1") == 88.05060698409301
21552116

2156-
@skip_if_server_version_lt("3.2.0")
21572117
async def test_cluster_georadius_store(self, r: ValkeyCluster) -> None:
21582118
values = (2.1909389952632, 41.433791470673, "place1") + (
21592119
2.1873744593677,
@@ -2168,7 +2128,6 @@ async def test_cluster_georadius_store(self, r: ValkeyCluster) -> None:
21682128
assert await r.zrange("{foo}places_barcelona", 0, -1) == [b"place1"]
21692129

21702130
@skip_unless_arch_bits(64)
2171-
@skip_if_server_version_lt("3.2.0")
21722131
async def test_cluster_georadius_store_dist(self, r: ValkeyCluster) -> None:
21732132
values = (2.1909389952632, 41.433791470673, "place1") + (
21742133
2.1873744593677,
@@ -2201,7 +2160,6 @@ async def test_cluster_keys(self, r: ValkeyCluster) -> None:
22012160
assert set(await r.keys(pattern="test*", target_nodes="primaries")) == keys
22022161

22032162
# SCAN COMMANDS
2204-
@skip_if_server_version_lt("2.8.0")
22052163
async def test_cluster_scan(self, r: ValkeyCluster) -> None:
22062164
await r.set("a", 1)
22072165
await r.set("b", 2)
@@ -2220,7 +2178,6 @@ async def test_cluster_scan(self, r: ValkeyCluster) -> None:
22202178
assert sorted(cursors.keys()) == sorted(node.name for node in nodes)
22212179
assert all(cursor == 0 for cursor in cursors.values())
22222180

2223-
@skip_if_server_version_lt("6.0.0")
22242181
async def test_cluster_scan_type(self, r: ValkeyCluster) -> None:
22252182
await r.sadd("a-set", 1)
22262183
await r.sadd("b-set", 1)
@@ -2243,7 +2200,6 @@ async def test_cluster_scan_type(self, r: ValkeyCluster) -> None:
22432200
assert sorted(cursors.keys()) == sorted(node.name for node in nodes)
22442201
assert all(cursor == 0 for cursor in cursors.values())
22452202

2246-
@skip_if_server_version_lt("2.8.0")
22472203
async def test_cluster_scan_iter(self, r: ValkeyCluster) -> None:
22482204
keys_all = []
22492205
keys_1 = []
@@ -2272,7 +2228,6 @@ async def test_cluster_randomkey(self, r: ValkeyCluster) -> None:
22722228
await r.set(key, 1)
22732229
assert await r.randomkey(target_nodes=node) in (b"{foo}a", b"{foo}b", b"{foo}c")
22742230

2275-
@skip_if_server_version_lt("6.0.0")
22762231
async def test_acl_log(
22772232
self, r: ValkeyCluster, create_valkey: Callable[..., ValkeyCluster]
22782233
) -> None:

0 commit comments

Comments
 (0)