Skip to content

Test suite: Add more test coverage for warn_if_unexpected_params() (only on Julia versions prior to 1.6) #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025
Merged

Test suite: Add more test coverage for warn_if_unexpected_params() (only on Julia versions prior to 1.6) #75

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b04b542
Test suite: Add more test coverage for `warn_if_unexpected_params()` …
DilumAluthge Apr 29, 2025
929a504
Fix a test error
DilumAluthge Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import Distributed
import Test

# Bring some names into scope, just for convenience:
using Test: @testset, @test
using Test: @testset, @test, @test_logs

const original_JULIA_DEBUG = strip(get(ENV, "JULIA_DEBUG", ""))
if isempty(original_JULIA_DEBUG)
Expand Down Expand Up @@ -60,3 +60,16 @@ end
println("# END script output")

end # testset "SlurmClusterManager.jl"

@testset "warn_if_unexpected_params()" begin
if Base.VERSION >= v"1.6"
# This test is not relevant for Julia 1.6+
else
params = Dict(:env => ["foo" => "bar"])
SlurmClusterManager.warn_if_unexpected_params(params)
@test_logs(
(:warn, "The user provided the `env` kwarg, but SlurmClusterManager.jl's support for the `env` kwarg requires Julia 1.6 or later"),
SlurmClusterManager.warn_if_unexpected_params(params),
)
end
end