Skip to content

add 0.7-compatible showarg methods #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

RalphAS
Copy link
Contributor

@RalphAS RalphAS commented Aug 3, 2018

This change adds versions of the showarg methods compatible with the usage in 0.7 Base.
The old ShowItLikeYouBuildIt versions are still used with older Julia.
Output format is the same as in the earlier versions of Interpolations.
Corresponding tests are re-enabled.

@codecov-io
Copy link

codecov-io commented Aug 3, 2018

Codecov Report

Merging #220 into master will increase coverage by 3.62%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   82.03%   85.65%   +3.62%     
==========================================
  Files          27       27              
  Lines        1002     1046      +44     
==========================================
+ Hits          822      896      +74     
+ Misses        180      150      -30
Impacted Files Coverage Δ
src/io.jl 83.14% <66.66%> (+83.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c380b0...57109c9. Read the comment docs.

@timholy
Copy link
Member

timholy commented Aug 11, 2018

Just noting this is a really crucial PR: we have decided we are not upgrading ShowItLikeYouBuildIt for 0.7, so we need to ditch the dependency and go 0.7+. There are some conflicts here but I am fixing them now.

@tomasaschan
Copy link
Contributor

we need to ditch the dependency and go 0.7+

Is it possible to specify that it is a dependency for 0.6, but from 0.7 and up? Since there are quite a lot of things you need to update in your code to move between 0.6 and 0.7/1.0, I think it would be nice if we could have as long a time window as possible where we support both.

@timholy
Copy link
Member

timholy commented Sep 18, 2018

Incorporated into #226

@timholy timholy closed this Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants