cross link issue about kwarg special case

oxinabox · web-flow · commit 941fd55da871 · 2021-06-11T11:22:19.000+01:00
diff --git a/src/rules.jl b/src/rules.jl
@@ -117,7 +117,8 @@ rrule(::Any, ::Vararg{Any}) = nothing
 
 # if no config is present then fallback to config-less rules
 rrule(::RuleConfig, f, args...; kwargs...) = rrule(f, args...; kwargs...)
-#TODO do we need to do something for kwargs special here for performance?
+# TODO do we need to do something for kwargs special here for performance?
+# See: https://github.com/JuliaDiff/ChainRulesCore.jl/issues/368
 
 # Manual fallback for keyword arguments. Usually this would be generated by
 #

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,8 @@ rrule(::Any, ::Vararg{Any}) = nothing`
`117`	`117`
`118`	`118`	`# if no config is present then fallback to config-less rules`
`119`	`119`	`rrule(::RuleConfig, f, args...; kwargs...) = rrule(f, args...; kwargs...)`
`120`		`-#TODO do we need to do something for kwargs special here for performance?`
	`120`	`+# TODO do we need to do something for kwargs special here for performance?`
	`121`	`+# See: https://github.com/JuliaDiff/ChainRulesCore.jl/issues/368`
`121`	`122`
`122`	`123`	`# Manual fallback for keyword arguments. Usually this would be generated by`
`123`	`124`	`#`