fixup

Author: mcabbott

src/rulesets/Base/mapreduce.jl

@@ -177,7 +177,7 @@ for mimum in (:minimum, :maximum)
                 _, one_back = rrule_via_ad(config, f, xs[ind])
                 df, one_dx_raw = one_back(unthunk(dy))
                 one_dx = unthunk(one_dx_raw)
-                x_thunk = @thunk project(_zerolike_writeat(xs, one_dx, dims, ind...))
+                x_thunk = @thunk project(_zerolike_writeat(xs, one_dx, dims, ind))
                 x_ithunk = InplaceableThunk(x_thunk) do dxs
                     view(dxs, ind) .+= one_dx
                     dxs

test/rulesets/Base/mapreduce.jl

@@ -117,11 +117,11 @@ const CFG = ChainRulesTestUtils.ADviaRuleConfig()
 
     @testset "maximum(f, xs)" begin
         # This calls back into AD
-        test_rrule(maximum, abs, [-4.0, 2.0, 2.0], check_inferred=false)
-        test_rrule(minimum, sqrt, Float64[1 2; 3 4], check_inferred=false)
-        test_rrule(maximum, Multiplier(2.0), [2.0, 4.0, 8.0], check_inferred=false)  # Multiplier defined in test_helpers.jl
+        test_rrule(maximum, abs, [-4.0, 2.0, 2.0])
+        test_rrule(minimum, sqrt, Float64[1 2; 3 4])
+        test_rrule(maximum, Multiplier(2.0), [2.0, 4.0, 8.0])  # Multiplier defined in test_helpers.jl
 
-        # dims keyword
+        # dims keyword -- these need to call `rrule_via_ad(broadcast, ...`
         @test_skip test_rrule(maximum, sqrt, Float64[1 2; 3 4], fkwargs=(;dims=1), check_inferred=false)
         @test_skip test_rrule(minimum, abs, randn(3,3), fkwargs=(;dims=2), check_inferred=false)