[FIR] Remove incorrect fast-path from @PublishedAPI computation for binary declarations

Published API effective visibility depends not only on `@PublishedAPI`
annotation on the declaration, but also on this annotation on the parent
declaration, so it's illegal to just skip all not annotated declarations

^KT-74040 Fixed

Author: demiurg906

analysis/low-level-api-fir/testData/getOrBuildFirBinary/publishedApi/publishedApiClass.txt

@@ -7,6 +7,6 @@ FIR source kind: KtRealSourceElementKind
 
 FIR element rendered:
 @R|kotlin/PublishedApi|() internal final [ResolvedTo(BODY_RESOLVE)] [LazyPublishedApiEffectiveVisibilityKey=public] class Foo : R|kotlin/Any| {
-    public [ResolvedTo(BODY_RESOLVE)] [ContainingClassKey=Foo] constructor(): R|Foo|
+    public [ResolvedTo(BODY_RESOLVE)] [ContainingClassKey=Foo, LazyPublishedApiEffectiveVisibilityKey=public] constructor(): R|Foo|
 
 }

compiler/fir/semantics/src/org/jetbrains/kotlin/fir/resolve/transformers/publishedApiEffectiveVisibility.kt

@@ -67,7 +67,7 @@ fun computePublishedApiEffectiveVisibility(
     )
 }
 
-fun computePublishedApiEffectiveVisibility(
+private fun computePublishedApiEffectiveVisibility(
     hasPublishedApiAnnotation: Boolean,
     visibility: Visibility,
     selfEffectiveVisibility: EffectiveVisibility,
@@ -112,8 +112,6 @@ fun FirMemberDeclaration.setLazyPublishedVisibility(annotations: List<FirAnnotat
 }
 
 fun FirMemberDeclaration.setLazyPublishedVisibility(hasPublishedApi: Boolean, parentProperty: FirProperty?, session: FirSession) {
-    if (!hasPublishedApi) return
-
     lazyPublishedApiEffectiveVisibility = lazy {
         val containingClassLookupTag = (when {
             parentProperty != null -> parentProperty.symbol.callableId.classId
@@ -125,9 +123,9 @@ fun FirMemberDeclaration.setLazyPublishedVisibility(hasPublishedApi: Boolean, pa
         val status = status as FirResolvedDeclarationStatus
         val parentSymbol = containingClassLookupTag?.toSymbol(session)
         computePublishedApiEffectiveVisibility(
-            hasPublishedApiAnnotation = true,
+            hasPublishedApiAnnotation = hasPublishedApi,
             visibility = status.visibility,
-            selfEffectiveVisibility = status.effectiveVisibility,
+            selfEffectiveVisibility = status.visibility.toEffectiveVisibility(parentSymbol, forClass = this is FirClass),
             containingClassLookupTag = containingClassLookupTag,
             parentEffectiveVisibility = parentProperty?.effectiveVisibility ?: parentSymbol?.effectiveVisibility
             ?: EffectiveVisibility.Public,

compiler/testData/loadJava/compiledKotlin/visibility/PublishedApi.fir.k1.txt

@@ -31,7 +31,7 @@ internal final [HasNoEnumEntriesKey=true, IsNewPlaceForBodyGeneration=false] cla
     @R|kotlin/PublishedApi|() internal [ContainingClassKey=Internal, LazyPublishedApiEffectiveVisibilityKey=internal] constructor(foo: R|kotlin/String|): R|test/Internal|
 
     @R|kotlin/PublishedApi|() internal final [HasNoEnumEntriesKey=true, IsNewPlaceForBodyGeneration=false, LazyPublishedApiEffectiveVisibilityKey=internal] class Nested : R|kotlin/Any| {
-        public [ContainingClassKey=Nested] constructor(): R|test/Internal.Nested|
+        public [ContainingClassKey=Nested, LazyPublishedApiEffectiveVisibilityKey=internal] constructor(): R|test/Internal.Nested|
 
     }
 
@@ -58,7 +58,7 @@ public final [HasNoEnumEntriesKey=true, IsNewPlaceForBodyGeneration=false] class
     @R|kotlin/PublishedApi|() internal [ContainingClassKey=Public, LazyPublishedApiEffectiveVisibilityKey=public] constructor(foo: R|kotlin/String|): R|test/Public|
 
     @R|kotlin/PublishedApi|() internal final [HasNoEnumEntriesKey=true, IsNewPlaceForBodyGeneration=false, LazyPublishedApiEffectiveVisibilityKey=public] class Nested : R|kotlin/Any| {
-        public [ContainingClassKey=Nested] constructor(): R|test/Public.Nested|
+        public [ContainingClassKey=Nested, LazyPublishedApiEffectiveVisibilityKey=public] constructor(): R|test/Public.Nested|
 
     }
 
@@ -67,8 +67,8 @@ public final [HasNoEnumEntriesKey=true, IsNewPlaceForBodyGeneration=false] class
 @R|kotlin/PublishedApi|() internal final [HasNoEnumEntriesKey=true, IsNewPlaceForBodyGeneration=false, LazyPublishedApiEffectiveVisibilityKey=public] class Published : R|kotlin/Any| {
     @R|kotlin/PublishedApi|() internal final [LazyPublishedApiEffectiveVisibilityKey=public] fun method(): R|kotlin/Unit|
 
-    public final val foo: R|kotlin/String|
-        public [ContainingClassKey=Published] get(): R|kotlin/String|
+    public final [LazyPublishedApiEffectiveVisibilityKey=public] val foo: R|kotlin/String|
+        public [ContainingClassKey=Published, LazyPublishedApiEffectiveVisibilityKey=public] get(): R|kotlin/String|
 
     @PROPERTY:R|kotlin/PublishedApi|() internal final [LazyPublishedApiEffectiveVisibilityKey=public] val prop: R|kotlin/Int|
         internal [ContainingClassKey=Published, LazyPublishedApiEffectiveVisibilityKey=public] get(): R|kotlin/Int|
@@ -85,7 +85,7 @@ public final [HasNoEnumEntriesKey=true, IsNewPlaceForBodyGeneration=false] class
     @R|kotlin/PublishedApi|() internal [ContainingClassKey=Published, LazyPublishedApiEffectiveVisibilityKey=public] constructor(foo: R|kotlin/String|): R|test/Published|
 
     @R|kotlin/PublishedApi|() internal final [HasNoEnumEntriesKey=true, IsNewPlaceForBodyGeneration=false, LazyPublishedApiEffectiveVisibilityKey=public] class Nested : R|kotlin/Any| {
-        public [ContainingClassKey=Nested] constructor(): R|test/Published.Nested|
+        public [ContainingClassKey=Nested, LazyPublishedApiEffectiveVisibilityKey=public] constructor(): R|test/Published.Nested|
 
     }
 

compiler/testData/loadJava/compiledKotlin/visibility/PublishedApi.fir.k2.txt

@@ -31,7 +31,7 @@ internal final [HasNoEnumEntriesKey=true, IsNewPlaceForBodyGeneration=false] cla
     @R|kotlin/PublishedApi|() internal [ContainingClassKey=Internal, LazyPublishedApiEffectiveVisibilityKey=internal] constructor(): R|test/Internal|
 
     @R|kotlin/PublishedApi|() internal final [HasNoEnumEntriesKey=true, IsNewPlaceForBodyGeneration=false, LazyPublishedApiEffectiveVisibilityKey=internal] class Nested : R|kotlin/Any| {
-        public [ContainingClassKey=Nested] constructor(): R|test/Internal.Nested|
+        public [ContainingClassKey=Nested, LazyPublishedApiEffectiveVisibilityKey=internal] constructor(): R|test/Internal.Nested|
 
     }
 
@@ -58,7 +58,7 @@ public final [HasNoEnumEntriesKey=true, IsNewPlaceForBodyGeneration=false] class
     @R|kotlin/PublishedApi|() internal [ContainingClassKey=Public, LazyPublishedApiEffectiveVisibilityKey=public] constructor(): R|test/Public|
 
     @R|kotlin/PublishedApi|() internal final [HasNoEnumEntriesKey=true, IsNewPlaceForBodyGeneration=false, LazyPublishedApiEffectiveVisibilityKey=public] class Nested : R|kotlin/Any| {
-        public [ContainingClassKey=Nested] constructor(): R|test/Public.Nested|
+        public [ContainingClassKey=Nested, LazyPublishedApiEffectiveVisibilityKey=public] constructor(): R|test/Public.Nested|
 
     }
 
@@ -67,8 +67,8 @@ public final [HasNoEnumEntriesKey=true, IsNewPlaceForBodyGeneration=false] class
 @R|kotlin/PublishedApi|() internal final [HasNoEnumEntriesKey=true, IsNewPlaceForBodyGeneration=false, LazyPublishedApiEffectiveVisibilityKey=public] class Published : R|kotlin/Any| {
     @R|kotlin/PublishedApi|() internal final [LazyPublishedApiEffectiveVisibilityKey=public] fun method(): R|kotlin/Unit|
 
-    public final val foo: R|kotlin/String|
-        public [ContainingClassKey=Published] get(): R|kotlin/String|
+    public final [LazyPublishedApiEffectiveVisibilityKey=public] val foo: R|kotlin/String|
+        public [ContainingClassKey=Published, LazyPublishedApiEffectiveVisibilityKey=public] get(): R|kotlin/String|
 
     @PROPERTY:R|kotlin/PublishedApi|() internal final [LazyPublishedApiEffectiveVisibilityKey=public] val prop: R|kotlin/Int|
         internal [ContainingClassKey=Published, LazyPublishedApiEffectiveVisibilityKey=public] get(): R|kotlin/Int|
@@ -85,7 +85,7 @@ public final [HasNoEnumEntriesKey=true, IsNewPlaceForBodyGeneration=false] class
     @R|kotlin/PublishedApi|() internal [ContainingClassKey=Published, LazyPublishedApiEffectiveVisibilityKey=public] constructor(): R|test/Published|
 
     @R|kotlin/PublishedApi|() internal final [HasNoEnumEntriesKey=true, IsNewPlaceForBodyGeneration=false, LazyPublishedApiEffectiveVisibilityKey=public] class Nested : R|kotlin/Any| {
-        public [ContainingClassKey=Nested] constructor(): R|test/Published.Nested|
+        public [ContainingClassKey=Nested, LazyPublishedApiEffectiveVisibilityKey=public] constructor(): R|test/Published.Nested|
 
     }