Should the "effects and epics" rules from the main RxJS plugin be split out? #132
JasonWeinzierl
started this conversation in
Polls
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
This plugin has some rules that are only relevant when using NgRx or redux-observable.
redux-observable
has since switched to maintenance mode, and NgRx is Angular-specific.In my opinion, those rules are only relevant in the context of Angular, they add confusion about what rules are helpful for all RxJS users versus what are library-specific, and they don't belong in the main plugin.
There are a few options here:
eslint-plugin-rxjs-angular-x
plugin: https://github.com/JasonWeinzierl/eslint-plugin-rxjs-angular-x . I've started that fork for the same reasons as this one, and so it may start to grow into a larger hub for Angular-specific rules and configurations.rxjs/no-cyclic-action
(https://ngrx.io/guide/eslint-plugin/rules/avoid-cyclic-effects), so they might be willing to take on the other NgRx-specific rules. This would leave redux-observable owners behind, but, as mentioned, that library might be falling out of use anyways.5 votes ·
Beta Was this translation helpful? Give feedback.
All reactions