Skip to content

Commit addb5f7

Browse files
GooolerJakeWharton
authored andcommitted
Minor configuration cleanups
1 parent eedfb02 commit addb5f7

File tree

3 files changed

+30
-22
lines changed

3 files changed

+30
-22
lines changed

.github/workflows/build.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
pull_request: {}
55
push:
66
branches:
7-
- '*'
7+
- 'trunk'
88
tags:
99
- '*'
1010

@@ -19,7 +19,7 @@ jobs:
1919
distribution: 'zulu'
2020
java-version-file: .github/workflows/.java-version
2121

22-
- uses: gradle/actions/wrapper-validation@v4
22+
- uses: gradle/actions/setup-gradle@v4
2323
- run: ./gradlew build
2424
- run: build/dependency-tree-diff.jar --help
2525

build.gradle

Lines changed: 15 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
1-
import org.jetbrains.kotlin.gradle.tasks.KotlinJvmCompile
21
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
2+
import org.jetbrains.kotlin.gradle.tasks.KotlinJvmCompile
33

44
buildscript {
5+
repositories {
6+
mavenCentral()
7+
}
58
dependencies {
69
classpath libs.kotlin.gradle.plugin
710
}
@@ -20,35 +23,37 @@ dependencies {
2023
r8 libs.r8
2124
}
2225

26+
def targetJavaVersion = 11
27+
2328
tasks.withType(JavaCompile).configureEach {
24-
sourceCompatibility = JavaVersion.VERSION_11
25-
targetCompatibility = JavaVersion.VERSION_11
29+
options.release = targetJavaVersion
2630
}
2731

2832
tasks.withType(KotlinJvmCompile).configureEach {
2933
compilerOptions {
30-
jvmTarget = JvmTarget.JVM_11
34+
jvmTarget = JvmTarget.fromTarget(targetJavaVersion.toString())
3135
freeCompilerArgs.addAll(
3236
'-Xno-call-assertions',
3337
'-Xno-param-assertions',
3438
'-Xno-receiver-assertions',
39+
"-Xjdk-release=$targetJavaVersion",
3540
)
3641
}
3742
}
3843

39-
def fatJarProvider = tasks.register('fatJar', Jar) { task ->
40-
task.dependsOn(configurations.named('runtimeClasspath'))
41-
task.dependsOn(tasks.named('jar'))
44+
tasks.named('jar', Jar) {
45+
// We don't need the thin jar, use the fatJar instead.
46+
enabled = false
47+
}
4248

49+
def fatJarProvider = tasks.register('fatJar', Jar) { task ->
4350
task.archiveClassifier = 'fat'
4451

4552
task.manifest {
4653
attributes 'Main-Class': 'com.jakewharton.gradle.dependencies.DependencyTreeDiff'
4754
}
4855

49-
def sourceClasses = sourceSets.main.output.classesDirs
50-
task.inputs.files(sourceClasses)
51-
task.from files(sourceClasses)
56+
task.from sourceSets.named('main').map { it.output }
5257
task.from configurations.named('runtimeClasspath').map {
5358
it.asFileTree.files.collect { it.isDirectory() ? it : zipTree(it) }
5459
}
@@ -111,13 +116,3 @@ tasks.named('assemble').configure { task ->
111116
artifacts {
112117
archives file: binaryFile, name: 'binary', type: 'jar', builtBy: binaryJar, classifier: 'binary'
113118
}
114-
115-
buildscript {
116-
repositories {
117-
mavenCentral()
118-
}
119-
}
120-
repositories {
121-
mavenCentral()
122-
google()
123-
}

settings.gradle

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,17 @@ plugins {
22
id 'org.gradle.toolchains.foojay-resolver-convention' version '1.0.0'
33
}
44

5+
dependencyResolutionManagement {
6+
repositories {
7+
mavenCentral()
8+
google {
9+
mavenContent {
10+
includeGroupAndSubgroups("androidx")
11+
includeGroupAndSubgroups("com.android")
12+
includeGroupAndSubgroups("com.google")
13+
}
14+
}
15+
}
16+
}
17+
518
rootProject.name = 'dependency-tree-diff'

0 commit comments

Comments
 (0)