fix: avoid NPE on empty Window Element properties

- fixes #2183

Signed-off-by: Andreas Reichel <[email protected]>

Author: manticore-projects

build.gradle

@@ -178,7 +178,7 @@ tasks.register('xmldoc', Javadoc) {
     )
 
     source = sourceSets.main.allJava
-    include("build/generated/javacc/net/sf/jsqlparser/parser/*.java" )
+    include("**/javacc/net/sf/jsqlparser/parser/*.java" )
 
     destinationDir = reporting.file("xmlDoclet")
     options.docletpath = configurations.xmlDoclet.files as List

src/main/java/net/sf/jsqlparser/util/TablesNamesFinder.java

@@ -804,11 +804,17 @@ public <S> Void visit(AnalyticExpression analytic, S context) {
         }
 
         if (analytic.getWindowElement() != null) {
-            analytic.getWindowElement().getRange().getStart().getExpression().accept(this,
-                    context);
-            analytic.getWindowElement().getRange().getEnd().getExpression().accept(this,
-                    context);
-            analytic.getWindowElement().getOffset().getExpression().accept(this, context);
+            if (analytic.getWindowElement().getRange().getStart().getExpression() != null) {
+                analytic.getWindowElement().getRange().getStart().getExpression().accept(this,
+                        context);
+            }
+            if (analytic.getWindowElement().getRange().getEnd().getExpression() != null) {
+                analytic.getWindowElement().getRange().getEnd().getExpression().accept(this,
+                        context);
+            }
+            if (analytic.getWindowElement().getOffset() != null) {
+                analytic.getWindowElement().getOffset().getExpression().accept(this, context);
+            }
         }
         return null;
     }

src/test/java/net/sf/jsqlparser/util/TablesNamesFinderTest.java

@@ -661,5 +661,25 @@ void testInsertTableIssue() throws JSQLParserException {
         tables = TablesNamesFinder.findTables(sqlStr);
         assertThat(tables).containsExactlyInAnyOrder("the_cool_db.the_table");
     }
+
+    @Test
+    void testIssue2183() throws JSQLParserException {
+        String sqlStr = "SELECT\n" +
+                "\tsubscriber_id,\n" +
+                "\tsum(1) OVER (PARTITION BY subscriber_id\n" +
+                "ORDER BY\n" +
+                "\tstat_time ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW ) AS stop_id\n" +
+                "FROM\n" +
+                "\t(\n" +
+                "\tSELECT\n" +
+                "\t\tsubscriber_id,\n" +
+                "\t\tstat_time\n" +
+                "\tFROM\n" +
+                "\t\tlocation_subscriber AS mid2 WINDOW w AS (PARTITION BY subscriber_id\n" +
+                "\tORDER BY\n" +
+                "\t\tstat_time ROWS BETWEEN 1 PRECEDING AND 1 PRECEDING ) )";
+        Set<String> tables = TablesNamesFinder.findTables(sqlStr);
+        assertThat(tables).containsExactlyInAnyOrder("location_subscriber");
+    }
 }