Skip to content

Commit 74b458a

Browse files
mockersfItsDoot
authored andcommitted
Better bloom default settings (bevyengine#6546)
# Objective - Use better defaults for bloom ## Solution - Divide the intensity by 3. It's still noticeable - Change the mip level? (not sure about that change, it's from a discussion with @superdump) ### bloom example main: <img width="1392" alt="Screenshot 2022-11-11 at 01 09 26" src="https://user-images.githubusercontent.com/8672791/201232996-20d6cf65-2511-41bc-979b-f2c193e4e4e6.png"> this pr: <img width="1392" alt="Screenshot 2022-11-11 at 01 08 00" src="https://user-images.githubusercontent.com/8672791/201232987-b1ebad2a-4ebf-4296-a91b-aab898544a9d.png"> ### bistro scene main: <img width="1392" alt="Screenshot 2022-11-11 at 01 16 42" src="https://user-images.githubusercontent.com/8672791/201233028-526999a3-0060-44f7-b0dd-f78666b06c1d.png"> this pr: <img width="1392" alt="Screenshot 2022-11-11 at 01 15 12" src="https://user-images.githubusercontent.com/8672791/201233044-50201034-e881-40e1-8455-76cabc621a9b.png">
1 parent 0a54100 commit 74b458a

File tree

1 file changed

+3
-3
lines changed
  • crates/bevy_core_pipeline/src/bloom

1 file changed

+3
-3
lines changed

crates/bevy_core_pipeline/src/bloom/mod.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ pub struct BloomSettings {
149149
/// Scale used when upsampling (default: 1.0).
150150
pub scale: f32,
151151

152-
/// Intensity of the bloom effect (default: 1.0).
152+
/// Intensity of the bloom effect (default: 0.3).
153153
pub intensity: f32,
154154
}
155155

@@ -159,7 +159,7 @@ impl Default for BloomSettings {
159159
threshold: 1.0,
160160
knee: 0.1,
161161
scale: 1.0,
162-
intensity: 1.0,
162+
intensity: 0.3,
163163
}
164164
}
165165
}
@@ -805,5 +805,5 @@ fn queue_bloom_bind_groups(
805805
}
806806

807807
fn calculate_mip_count(min_view: u32) -> u32 {
808-
((min_view as f32).log2().round() as u32 - 1).max(1)
808+
((min_view as f32).log2().round() as i32 - 3).max(1) as u32
809809
}

0 commit comments

Comments
 (0)