Skip to content

Fix comparison for indifferent metric type in report #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Alexsandruss
Copy link
Contributor

@Alexsandruss Alexsandruss commented Mar 20, 2025

Description

Usage of == operator for indifferent metric type led to errors due to unequal indices of compared data frames in some cases. pd.DataFrame's method eq handles these cases and assigns values correctly.


PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

@Alexsandruss Alexsandruss added the bug Something isn't working label Mar 20, 2025
@Alexsandruss Alexsandruss marked this pull request as ready for review March 20, 2025 11:51
@Alexsandruss Alexsandruss merged commit 1103aad into IntelPython:main Mar 20, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants